Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider tying enableDebugMode() availability to third-party cookie eligibility #57

Closed
alexmturner opened this issue Jun 9, 2023 · 3 comments
Closed

Consider tying enableDebugMode() availability to third-party cookie eligibility #57

alexmturner opened this issue Jun 9, 2023 · 3 comments
Labels
compat Issue may affect web compatibility enhancement New feature or request

Comments

@alexmturner
Copy link
Collaborator

This would ensure parity with what is available through cookies and allow for the temporary debugging mechanism to 'automatically' be removed when third-party cookies are.
@alexmturner alexmturner added compat Issue may affect web compatibility enhancement New feature or request labels Jun 28, 2023
@alexmturner
Copy link
Collaborator Author

Note that this change would not be backwards compatabile in the case where a frame that does not have third-party cookie eligibility runs an Protected Audience auction or Shared Storage operation and tries to use Private Aggregation's debug mode.

In that case, we could avoid defining enableDebugMode() to allow easy detection of this case. If we are more concerned about breaking existing code, we could instead silently drop the enableDebugMode() call.

alexmturner added a commit that referenced this issue Aug 22, 2023
@alexmturner
Spec: Allow debug mode to be disabled arbitrarily by the user agent.
6f80684 
Adds logic that allows for debug mode to be disabled even if
enableDebugMode() is called. This addresses issue #57.

As a drive-by, adds an issue for an assert that is currently hit.
@alexmturner alexmturner mentioned this issue Aug 22, 2023
Merged
alexmturner added a commit that referenced this issue Sep 11, 2023
@alexmturner
Clarify when debug mode is enabled
2d18cb4 
Per issue #57, we tie debug mode to third-party cookie eligibility. See also the related spec change in #90.
@alexmturner alexmturner mentioned this issue Sep 11, 2023
Merged
alexmturner added a commit that referenced this issue Sep 25, 2023
@alexmturner
Clarify when debug mode is enabled (#93)
ec382c4 
Per issue #57, we tie debug mode to third-party cookie eligibility. See also the related spec change in #90.
alexmturner added a commit that referenced this issue Sep 25, 2023
@alexmturner
Spec: Allow debug mode to be disabled arbitrarily by the user agent. (#…
2eb3d35 
…90)

Adds logic that allows for debug mode to be disabled even if
enableDebugMode() is called. This addresses issue #57.

As a drive-by, adds an issue for an assert that is currently hit.
@alexmturner
Copy link
Collaborator Author

Closing as this has been implemented

@nikijohnson4
Copy link

Thanks for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compat Issue may affect web compatibility enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexmturner @nikijohnson4