Spec: Allow debug mode to be disabled arbitrarily by the user agent. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds logic that allows for debug mode to be disabled even if enableDebugMode() is called. This addresses issue #57. As a drive-by, adds an issue for an assert that is currently hit.
|
@linnan-github, could you PTAL? Thanks! |
linnan-github
approved these changes
Aug 31, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Sep 11, 2023
Adds new feature params that allow for controlling debug mode eligibility. By default, this cl continues the current behavior of always allowing debug mode, so this cl should be a no-op unless one of the FeatureParams are force enabled/disabled. We add one param that allows for debug mode to be conditioned on third- party cookie eligibility. We plan to enable this in a follow-up cl. This cl also adds a kill switch param that disallows debug mode globally. See also the related spec change: patcg-individual-drafts/private-aggregation-api#90 Bug: 1476980 Change-Id: Iebd3cb9dbd4dfa9fb9322ac0bdf8b5f7408bf153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4822930 Reviewed-by: Theodore Olsauskas-Warren <[email protected]> Commit-Queue: Alex Turner <[email protected]> Reviewed-by: John Abd-El-Malek <[email protected]> Reviewed-by: Nan Lin <[email protected]> Reviewed-by: Qingxin Wu <[email protected]> Cr-Commit-Position: refs/heads/main@{#1195010}
|
cc @yoavweiss |
alexmturner
added a commit
that referenced
this pull request
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds logic that allows for debug mode to be disabled even if enableDebugMode() is called. This addresses issue #57. See also the corresponding explainer change: #93.
As a drive-by, adds an issue for an assert that is currently hit.
Preview | Diff