Skip to content

Commit

Permalink
Spec: Allow debug mode to be disabled arbitrarily by the user agent.
Browse files Browse the repository at this point in the history
Adds logic that allows for debug mode to be disabled even if
enableDebugMode() is called. This addresses issue #57.

As a drive-by, adds an issue for an assert that is currently hit.
  • Loading branch information
alexmturner committed Aug 22, 2023
1 parent cf92221 commit 6f80684
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions spec.bs
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,10 @@ enableDebugMode(optional PADebugModeOptions options)</dfn> method steps are:
: [=debug details/key=]
:: |debugKey|

1. Optionally, set |debugDetails| to a new [=debug details=].

Note: This allows the user agent to make debug mode unavailable globally or
just for certain callers.
1. [=map/Set=] |debugScopeMap|[|debugScope|] to |debugDetails|.

Issue: Ensure errors are of an appropriate type, e.g. {{InvalidAccessError}} is
Expand Down Expand Up @@ -436,6 +440,7 @@ To <dfn algorithm export>get a debug details</dfn> given a [=debug scope=]
1. Let |debugScopeMap| be the [=debug scope map=].
1. [=Assert=]: |debugScopeMap|[|debugScope|] [=map/exists=].
1. Return |debugScopeMap|[|debugScope|].
Issue: This should return a default when the scope does not exist.

To <dfn algorithm export>mark a debug scope complete</dfn> given a [=debug
scope=] |debugScope|:
Expand Down

0 comments on commit 6f80684

Please sign in to comment.