Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http): Add SVG diagrams for HTTP overview page #34251

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Jun 18, 2024

Description

This PR converts existing .png to use SVG format. The mermaid source are being added to shared assets in parallel.

Motivation

Reducing binary assets, maintenance of diagrams by adding source files.

How to review this PR

For convenience, it may be best to compare the preview URL generated here with the live page at https://developer.mozilla.org/en-US/docs/Web/HTTP/Overview

Related issues and pull requests

Shared assets

Source and generated files for these changes:

@bsmth bsmth added the reduce binary assets Efforts to remove or convert binary assets label Jun 18, 2024
@bsmth bsmth requested a review from a team as a code owner June 18, 2024 15:20
@bsmth bsmth requested review from teoli2003 and removed request for a team June 18, 2024 15:20
@github-actions github-actions bot added Content:HTTP HTTP docs size/s 6-50 LoC changed labels Jun 18, 2024
Copy link
Contributor

github-actions bot commented Jun 18, 2024

Preview URLs

Flaws (5)

URL: /en-US/docs/Web/HTTP/Overview
Title: An overview of HTTP
Flaw count: 5

  • images:
    • External image URL
    • External image URL
    • External image URL
    • External image URL
    • External image URL
External URLs (1)

URL: /en-US/docs/Web/HTTP/Overview
Title: An overview of HTTP

(comment last updated: 2024-06-18 16:12:15)

@Rumyra Rumyra requested review from Rumyra and removed request for teoli2003 June 19, 2024 10:36
@Rumyra Rumyra merged commit 5f0ee8a into mdn:main Jun 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:HTTP HTTP docs reduce binary assets Efforts to remove or convert binary assets size/s 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants