Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CSS): Replace png images with SVG equivalents #30820

Merged
merged 3 commits into from
Dec 8, 2023
Merged

chore(CSS): Replace png images with SVG equivalents #30820

merged 3 commits into from
Dec 8, 2023

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented Dec 6, 2023

Description

This PR replaces .png images with SVG equivalents.

Motivation

Repo maintenance & housekeeping - SVG can be diffed and are easier to maintain.

@bsmth bsmth requested a review from a team as a code owner December 6, 2023 10:03
@bsmth bsmth requested review from estelle and removed request for a team December 6, 2023 10:03
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023 •
edited

Preview URLs

(comment last updated: 2023-12-07 16:32:28)

@bsmth bsmth requested a review from pepelsbey December 7, 2023 09:55
teoli2003
teoli2003 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Member

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 +1

@teoli2003 teoli2003 merged commit 1f12f36 into mdn:main Dec 8, 2023
7 checks passed
@bsmth bsmth deleted the flex-diagrams branch December 8, 2023 10:55
@hamishwillee
Copy link
Collaborator

Is this a policy? I very much like the idea of prefer-SVG-by-default for images.

@bsmth
Copy link
Member Author

bsmth commented Dec 14, 2023

Is this a policy? I very much like the idea of prefer-SVG-by-default for images.

Not yet, I'm upgrading these in parallel whenever I'm working on a doc with .png diagrams, but I would love to do some more in '24 with a bit more coordination. We could consider freezing new .png additions for diagrams while we do some conversions. Good topic for a discussion, I think.

@hamishwillee
Copy link
Collaborator

Good topic for a discussion, I think.

Absolutely! If you create it, I'll join it.

@bsmth bsmth mentioned this pull request Dec 21, 2023
Closed
dipikabh pushed a commit to dipikabh/content that referenced this pull request Jan 17, 2024
@bsmth @dipikabh
chore(CSS): Replace png images with SVG equivalents (mdn#30820)
dfac7e5 
* chore(CSS): Replace png images with SVG equivalents

* fix:  text alignment

* fix:  text alignment
@bsmth bsmth mentioned this pull request Jan 19, 2024
Merged
2 tasks
@bsmth bsmth added the reduce binary assets Efforts to remove or convert binary assets label Jan 22, 2024
@bsmth
Copy link
Member Author

bsmth commented Jan 22, 2024

Good topic for a discussion, I think.

Absolutely! If you create it, I'll join it.

Thanks, @hamishwillee, put some thoughts here: https://github.com/orgs/mdn/discussions/631

Happy to see what you think!

@bsmth bsmth mentioned this pull request May 14, 2024
Merged
3 tasks
@bsmth bsmth mentioned this pull request Jun 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

@estelle estelle Awaiting requested review from estelle estelle is a code owner automatically assigned from mdn/yari-content-css

@pepelsbey pepelsbey Awaiting requested review from pepelsbey

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs reduce binary assets Efforts to remove or convert binary assets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bsmth @hamishwillee @teoli2003