Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use SVG for conditional reqs diagrams #33607

Merged
merged 5 commits into from
Jun 13, 2024
Merged

feat: Use SVG for conditional reqs diagrams #33607

merged 5 commits into from
Jun 13, 2024
+11 −11

Conversation

bsmth
Copy link
Member

@bsmth bsmth commented May 14, 2024 •
edited

Description

This PR converts existing .png to use SVG format. The mermaid source are being added to shared assets in parallel.

Motivation

Reducing binary assets, maintenance of diagrams by adding source files.

How to review this PR

For convenience, it may be best to compare the preview URL generated here with the live page at https://developer.mozilla.org/en-US/docs/Web/HTTP/Conditional_requests#use_cases

Related issues and pull requests

Shared assets

Source and generated files for these changes:

@bsmth bsmth added the reduce binary assets Efforts to remove or convert binary assets label May 14, 2024
@bsmth bsmth requested a review from a team as a code owner May 14, 2024 13:33
@bsmth bsmth requested review from teoli2003 and removed request for a team May 14, 2024 13:33
@github-actions github-actions bot added Content:HTTP HTTP docs size/xl >1000 LoC changed labels May 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 14, 2024 •
edited

Preview URLs

Flaws (11)

URL: /en-US/docs/Web/HTTP/Conditional_requests
Title: HTTP conditional requests
Flaw count: 11

  • images:
    • External image URL
    • External image URL
    • External image URL
    • External image URL
    • External image URL
    • and 6 more flaws omitted

(comment last updated: 2024-06-13 13:00:03)

@github-actions github-actions bot added size/s 6-50 LoC changed and removed size/xl >1000 LoC changed labels Jun 13, 2024
pepelsbey
pepelsbey approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks* good! Thank you :)

  • god bless the header override option in Chrome DevTools :)

@bsmth
Copy link
Member Author

bsmth commented Jun 13, 2024

Thank you! Going to merge, but would be nice if the dev env showed the images properly 😢

@bsmth bsmth merged commit 3c8eb35 into mdn:main Jun 13, 2024
8 checks passed
@bsmth bsmth deleted the conditional-reqs branch June 13, 2024 14:24
@bsmth bsmth mentioned this pull request Jun 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepelsbey pepelsbey pepelsbey approved these changes

@teoli2003 teoli2003 Awaiting requested review from teoli2003 teoli2003 is a code owner automatically assigned from mdn/yari-content-http

Assignees
No one assigned
Labels
Content:HTTP HTTP docs reduce binary assets Efforts to remove or convert binary assets size/s 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bsmth @pepelsbey