Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix setConfiguration default value handling to match implementations. #2691

Merged
merged 2 commits into from
Dec 2, 2021
Merged

Fix setConfiguration default value handling to match implementations. #2691

merged 2 commits into from
Dec 2, 2021

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Oct 22, 2021 •
edited by pr-preview bot
Loading

Fixes #2690.

Preview | Diff

@jan-ivar jan-ivar self-assigned this Oct 22, 2021
@jan-ivar
Copy link
Member Author

For review I recommend split view with whitespace hidden.

@jan-ivar jan-ivar merged commit 8a36da1 into w3c:main Dec 2, 2021
@jan-ivar jan-ivar deleted the configdefaults branch December 2, 2021 00:14
dontcallmedom added a commit that referenced this pull request Jan 28, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
f492d47 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request May 5, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
47aa9a2 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request Jul 19, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
bfaa022 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request Aug 19, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
cfce609 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
dontcallmedom added a commit that referenced this pull request Sep 27, 2022
@dontcallmedom
Document substantive changes since Rec as candidate amendments
f1f939b 
Candidate amendments process: https://www.w3.org/2021/Process-20211102/#candidate-changes
PR covered based on https://github.com/w3c/webrtc-pc/pulls?q=is%3Apr++-label%3AEditorial+merged%3A%3E2021-01-01+ (merged PRs since Jan 1 2021): #2679 #2680 #2686 #2687 #2689 #2691 #2700 #2704 #2708
@jan-ivar jan-ivar mentioned this pull request Aug 15, 2023
Closed
dontcallmedom added a commit to web-platform-tests/wpt that referenced this pull request Nov 15, 2023
@dontcallmedom
Add tests for w3c/webrtc-pc#2691 (#43166)
ae97638 
* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
@dontcallmedom dontcallmedom mentioned this pull request Nov 15, 2023
Merged
23 tasks
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 22, 2023
@dontcallmedom @moz-wptsync-bot
Bug 1864812 [wpt PR 43166] - Add tests for w3c/webrtc-pc#2691, a=test…
4128659 
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Nov 22, 2023
@dontcallmedom @moz-wptsync-bot
Bug 1864812 [wpt PR 43166] - Add tests for w3c/webrtc-pc#2691, a=test…
a7d5e22 
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 24, 2023
@dontcallmedom @moz-wptsync-bot
Bug 1864812 [wpt PR 43166] - Add tests for w3c/webrtc-pc#2691, a=test…
29a0612 
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166
vinnydiehl pushed a commit to vinnydiehl/mozilla-unified that referenced this pull request Nov 24, 2023
@dontcallmedom @moz-wptsync-bot
Bug 1864812 [wpt PR 43166] - Add tests for w3c/webrtc-pc#2691, a=test…
ee542fa 
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Nov 30, 2023
@marco-c
Bug 1864812 [wpt PR 43166] - Add tests for w3c/webrtc-pc#2691, a=test…
74b737b 
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166

UltraBlame original commit: 24de11145dec768a58f3c7754156ad2ead833c7f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Nov 30, 2023
@marco-c
Bug 1864812 [wpt PR 43166] - Add tests for w3c/webrtc-pc#2691, a=test…
6ea6d9d 
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166

UltraBlame original commit: 24de11145dec768a58f3c7754156ad2ead833c7f
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Nov 30, 2023
@marco-c
Bug 1864812 [wpt PR 43166] - Add tests for w3c/webrtc-pc#2691, a=test…
3d91c57 
…only

Automatic update from web-platform-tests
Add tests for w3c/webrtc-pc#2691 (#43166)

* Add tests for w3c/webrtc-pc#2691

https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-bundlePolicy.html#L67 already tests it for bundlePolicy
https://github.com/web-platform-tests/wpt/blob/8347f5b483e3b713443d06638d3662457107b3b0/webrtc/RTCConfiguration-iceTransportPolicy.html#L84C5-L84C68 tests it for iceTransportPolicy
This adds the relevant test for rtcpMuxPolicy

* Fix lint
--

wpt-commits: ae97638a3c85516ecfa82141e47c52ca2629eecf
wpt-pr: 43166

UltraBlame original commit: 24de11145dec768a58f3c7754156ad2ead833c7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvestrand alvestrand alvestrand approved these changes

@aboba aboba Awaiting requested review from aboba

@youennf youennf Awaiting requested review from youennf

Assignees

@jan-ivar jan-ivar

Labels
Editors can integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pc.setConfiguration()'s default value handling doesn't match implementations
2 participants
@jan-ivar @alvestrand