DOMTimeStamp is now EpochTimeStamp #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontcallmedom
requested changes
Oct 21, 2021
There was a problem hiding this comment.
since expires is a relative time to now (as discussed in #2674), I don't think EpochTimeStamp is correct
|
Ah, got it. Yeah, a high res time stamp would be better. |
|
The change of timestamp type is at #2674 |
|
Tooling is currently broken over this. Re-opening to consider temporarily merging this until #2674 has been resolved |
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2674
Preview | Diff