add Newsblur #107
Open
add Newsblur #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shgysk8zer0
requested changes
Sep 9, 2018
There was a problem hiding this comment.
Do you have an account to verify that it works? I'd never heard of NewsBlur before this.
I found an SVG version of the NewsBlur logo at https://www.newsblur.com/media/img/logo.svg but I don't think it can be used via <use> due to gradients and clip path, so it might require using an <img> instead.
|
@shgysk8zer0 I have tested it with newsblur and it work if I set the url hard in the calling function. But it isn't saved and I'm not sure how to debug this. |
|
It should be creating a URL like https://newsblur.com/?url=... Is that the correct URL and query? |
Firefox is removing this, so I shall as well
Adds preinstall script
This reverts commit 77a5b24.
This reverts commit b630da8.
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description and issue
I've added Newsblur as Feedreader
List of significant changes made
To do