Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad perceived performance of opening the panel #495

Closed
cadeyrn opened this issue Apr 16, 2023 · 1 comment · Fixed by #498
Closed

bad perceived performance of opening the panel #495

cadeyrn opened this issue Apr 16, 2023 · 1 comment · Fixed by #498
Assignees
@maxxcrawford
Labels
bug Something isn't working

Comments

@cadeyrn
Copy link

cadeyrn commented Apr 16, 2023 •
edited

STR:

  1. Click the Firefox Relay button in the extension menu

Actual:

  1. First you see an empty panel with the header row and the big blue button to create a custom mask on the bottom
  2. Then the blue button moves a bit up and a link below the button appears to create a random mask
  3. Then the existing masks and the filter field appears

It takes ~ 2 seconds until everything is there, every time you press the button. This gives the impression of a really bad performance.

Some ideas to consider:

  1. Is there something that could be cached so that it's fast from the second time you open the panel at least?
  2. Is it possible to let the blue button and the link for creating a random mask appear at the same time so that nothing moves? Even if it still takes the same time until everything is there it would improve the perceived performance if less visible steps are involved and no content moves.

add-on version: 2.7.0
@maxxcrawford
Copy link
Collaborator

@cadeyrn Thanks for filing this! We noticed the same thing last week and started on a fix. We'll have this resolved in our bug release!

@maxxcrawford maxxcrawford added the bug Something isn't working label Apr 17, 2023
maxxcrawford added a commit that referenced this issue Apr 17, 2023
@maxxcrawford
Fix MPP-3063 #495 - Use local storage to load inital masks
6ad4352
@maxxcrawford maxxcrawford mentioned this issue Apr 17, 2023
Closed
4 tasks
maxxcrawford added a commit that referenced this issue Apr 20, 2023
@maxxcrawford
Fix MPP-3063 and #495 / Reduce panel load time by storing API call an…
5b5ecca 
…d using local storage for masks
@maxxcrawford maxxcrawford mentioned this issue Apr 20, 2023
Merged
6 tasks
@maxxcrawford maxxcrawford linked a pull request Apr 20, 2023 that will close this issue
[MPP-3063] Reduce panel load time #498
Merged
6 tasks
maxxcrawford added a commit that referenced this issue Apr 20, 2023
@maxxcrawford
[MPP-3063] Reduce panel load time (#498)
8ca9c92 
* Fix MPP-3063 and #495 / Reduce panel load time by storing API call and using local storage for masks

* Update method for getting masks from API to mirror rest of add-on

* Update stats panel to use localStorage masks item

* Improve code legibility by moving mask element creation to seperate function from larger mask list builder function

* Remove extra save point when querying masks from the server

* Move logic to show empty state to buildMasksList() function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxxcrawford maxxcrawford

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[MPP-3063] Reduce panel load time mozilla/fx-private-relay-add-on
2 participants
@cadeyrn @maxxcrawford