[MPP-3063] Reduce panel load time #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d using local storage for masks
…unction from larger mask list builder function
44fd864
to
3fcffb5
Compare
4 tasks
maxxcrawford
commented
Apr 20, 2023
Comment on lines
+510
to
+511
| // Remove loading state | ||
| document.body.classList.remove("is-loading"); |
There was a problem hiding this comment.
Context: Moved this to the end of the buildMasksList() function. Previously, we were removing the loading state too early.
|
|
||
| // Generate and append each mask item to the mask list | ||
| masks.forEach( mask => { | ||
| const maskListItem = popup.panel.masks.utilities.buildMaskListItem(mask); |
There was a problem hiding this comment.
Context: This function was getting really big. Broke out the buildMaskListItem iteration to make it easier to read.
Comment on lines
+584
to
+585
| // TODO: Add toggle button back | ||
| // maskListItemAddressActions.append(maskListItemToggleButton); |
There was a problem hiding this comment.
Disregard this TODO. It is part of #473
codemist
reviewed
Apr 20, 2023
codemist
reviewed
Apr 20, 2023
codemist
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces the load time when a user is logged in and opens the panels to view their masks.
This fixes:
TODO
Build initial masks lists on local (stale) dateDisregarding for nowUpdate masks accordingly when API call finishes loading (add new masks, update status of other masks)Testing
For context, compare these actions to the production release with the same account.
$ npm run config:prod)Screenshots
TBD