Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated selectorSpread #117720

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Remove deprecated selectorSpread #117720

merged 1 commit into from
Aug 29, 2023

Conversation

kerthcet
Copy link
Member

@kerthcet kerthcet commented May 2, 2023 •
edited

What type of PR is this?

/kind feature
/sig scheduling
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #108444

Special notes for your reviewer:

Does this PR introduce a user-facing change?

ACTION REQUIRED: the kube-scheduler `selectorSpread` plugin has been removed, please use the `podTopologySpread` plugin instead.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 2, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 2, 2023
@kerthcet kerthcet mentioned this pull request May 2, 2023
Closed
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label May 2, 2023
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@alculquicondor
Copy link
Member

/hold
for #117649

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels May 2, 2023
@kerthcet
Copy link
Member Author

kerthcet commented May 4, 2023

/hold cancel
Ready for review now.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@alculquicondor
Copy link
Member

oh wait... but v1beta3 still could use the plugin, couldn't it?

@kerthcet
Copy link
Member Author

kerthcet commented May 5, 2023

Yes, we didn't add it to the validations of invalid plugins. Wait for one more release?

@alculquicondor
Copy link
Member

Yes, sorry for the confusion

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 25, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
alculquicondor
alculquicondor reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 699905f65f71bf277dbb8318fa01c3f3a32e818e

@kerthcet
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

@kerthcet: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-node-e2e-containerd 855b445 link unknown /test pull-kubernetes-node-e2e-containerd

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kerthcet
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit cd91351 into kubernetes:master Aug 29, 2023
13 of 14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 29, 2023
@sftim
Copy link
Contributor

sftim commented Sep 6, 2023

Changelog suggestion

-ACTION REQUIRED: Kube-scheduler selectorSpread plugin is removed, please use podTopologySpread plugin instead.
+ACTION REQUIRED: the kube-scheduler `selectorSpread` plugin has been removed; please use the `podTopologySpread` plugin instead.

Also, remember to get this change documented.

@kerthcet
Copy link
Member Author

Also, remember to get this change documented.

Updated, and will follow the documentation.

@kerthcet kerthcet deleted the feat/remove-selector-spread branch September 18, 2023 07:16
@kerthcet kerthcet mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alculquicondor alculquicondor alculquicondor left review comments

@chendave chendave Awaiting requested review from chendave

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@alculquicondor alculquicondor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.

remove SelectorSpread plugin
5 participants
@kerthcet @k8s-ci-robot @k8s-triage-robot @alculquicondor @sftim