Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: remove deprecated v1beta2 KubeSchedulerConfiguration component config #117649

Merged
merged 1 commit into from
May 3, 2023
Merged

scheduler: remove deprecated v1beta2 KubeSchedulerConfiguration component config #117649

merged 1 commit into from
May 3, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Apr 27, 2023 •
edited by liggitt

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

v1beta2 has been deprecated since v1.25(#111547), it can be removed in v1.28 as planed.

Which issue(s) this PR fixes:

Ref #117556

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kube-scheduler component config (KubeSchedulerConfiguration) kubescheduler.config.k8s.io/v1beta2 is removed in v1.28. Migrate kube-scheduler configuration files to kubescheduler.config.k8s.io/v1.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

-[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/785-scheduler-component-config-api

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 27, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Apr 27, 2023

/cc @kerthcet

@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@alexzielenski
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 27, 2023
@SataQiu
Copy link
Member Author

SataQiu commented Apr 28, 2023

/assign @ahg-g

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 28, 2023
@SataQiu SataQiu force-pushed the scheduler-remove-v1beta2-20230427 branch from bdb8552 to ed297f1 Compare April 28, 2023 01:56
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 28, 2023
kerthcet
kerthcet reviewed Apr 28, 2023
View reviewed changes
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks @SataQiu

pkg/scheduler/apis/config/scheme/scheme_test.go
@@ -1472,9 +890,9 @@ profiles:
{
Name: "VolumeBinding",
Args: runtime.RawExtension{
Object: &v1beta2.VolumeBindingArgs{
Object: &v1beta3.VolumeBindingArgs{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be a mistake before. 😄

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2023
@sanposhiho
Copy link
Member

Please update the release note something like:

kube-scheduler component config (KubeSchedulerConfiguration) v1beta2 is removed in v1.28. 
You need to migrate to KubeSchedulerConfiguration v1 if you use it.

@ahg-g
Copy link
Member

ahg-g commented May 2, 2023

/lgtm
/approve

@ahg-g
Copy link
Member

ahg-g commented May 2, 2023

/label api-review

@k8s-ci-robot k8s-ci-robot added the api-review Categorizes an issue or PR as actively needing an API review. label May 2, 2023
@alculquicondor alculquicondor mentioned this pull request May 2, 2023
Merged
@cici37
Copy link
Contributor

cici37 commented May 2, 2023

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 2, 2023
@SataQiu SataQiu force-pushed the scheduler-remove-v1beta2-20230427 branch from ed297f1 to 1f7c07f Compare May 3, 2023 13:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 3, 2023
@SataQiu
Copy link
Member Author

SataQiu commented May 3, 2023

/assign @liggitt
for api approve

@liggitt
Copy link
Member

liggitt commented May 3, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a4160ec2f67e85edc170a5786541a79933f75ed9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liggitt, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2023
@liggitt liggitt added this to API review completed, 1.28 in API Reviews May 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 47f1bd9 into kubernetes:master May 3, 2023
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 3, 2023
@cici37
Copy link
Contributor

cici37 commented May 9, 2023

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 9, 2023
@sanposhiho sanposhiho mentioned this pull request May 13, 2023
Merged
@bryfry bryfry mentioned this pull request Oct 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chendave chendave Awaiting requested review from chendave

@denkensk denkensk Awaiting requested review from denkensk

@ahg-g ahg-g Awaiting requested review from ahg-g

@kerthcet kerthcet Awaiting requested review from kerthcet

Assignees

@liggitt liggitt

@kerthcet kerthcet

@ahg-g ahg-g

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
API Reviews
Status: API review completed, 1.28
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@SataQiu @k8s-triage-robot @alexzielenski @k8s-ci-robot @sanposhiho @ahg-g @cici37 @liggitt @kerthcet