Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable core.autocrlf on Windows to prevent submodule diffs (fix #2886) #2888

Merged
merged 1 commit into from
Sep 15, 2023
Merged

Disable core.autocrlf on Windows to prevent submodule diffs (fix #2886) #2888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Disable core.autocrlf on Windows to prevent submodule diffs (fix #2886)
  • Loading branch information
@itchyny
itchyny committed Sep 10, 2023
commit 386c38e86768dd07072c5c282e61dd30b61b1b69
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,9 @@ jobs:
run:
shell: msys2 {0}
steps:
- name: Prepare git config
run: git config --system core.autocrlf false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want a comment why this is done?

Is it worth having some kind of regression test to make sure --version seem ok?

shell: bash
- name: Clone repository
uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -240,7 +243,7 @@ jobs:
- name: Test
run: |
make check VERBOSE=yes
git diff --exit-code --ignore-submodules
git diff --exit-code
- name: Upload Test Logs
if: ${{ failure() }}
uses: actions/upload-artifact@v3
Expand Down