Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable core.autocrlf on Windows to prevent submodule diffs (fix #2886) #2888

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

itchyny
Copy link
Contributor

@itchyny itchyny commented Sep 10, 2023

No description provided.

@itchyny itchyny linked an issue Sep 10, 2023 that may be closed by this pull request
@@ -207,6 +207,9 @@ jobs:
run:
shell: msys2 {0}
steps:
- name: Prepare git config
run: git config --system core.autocrlf false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want a comment why this is done?

Is it worth having some kind of regression test to make sure --version seem ok?

@itchyny itchyny merged commit 5ea1a4a into jqlang:master Sep 15, 2023
28 checks passed
@nicowilliams
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants