Finish migrating packaging pipeline to Github Actions. #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gregdenton @larsbijl @DiegoTavares Ping, could I get a review on this? Nothing new here, just migrating existing CI logic to Github Actions. |
|
How can I run the action @bcipriano to test? |
|
This pipeline relies on secrets which are stored at the ASWF level, so I don't think it will run in a fork or as a PR-driven action. In general that's ok because the pipeline is really only meant to run when new commits are merged into As a committer you should be able to do the following:
I used a setup like this to test the pipeline while I was working on it. See for example https://github.com/AcademySoftwareFoundation/OpenCue/actions/runs/199732120. |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link the Issue(s) this Pull Request is related to.
#715
Summarize your change.
This migrates all remaining build steps from the Azure file to the Github Actions pipeline. All artifacts now get uploaded to S3, to be used later by the release pipeline when creating the release.