Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fix issue where Universe Domain is not correctly set. #2423

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

PhongChuong
Copy link
Contributor

@PhongChuong PhongChuong commented Feb 28, 2024

This PR fixes an issue where the universe domain is not correctly set. This also adds integration tests to verify the change. This PR was created with @lqiu96's help.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2422 ☕️

This PR fixes an issue where the universe domain is not correctly set. This also adds integration tests to verify the change.
@PhongChuong PhongChuong requested a review from a team as a code owner February 28, 2024 19:49
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels Feb 28, 2024
@PhongChuong PhongChuong requested a review from a team as a code owner February 28, 2024 19:57
@PhongChuong PhongChuong merged commit b7ebd73 into main Feb 29, 2024
20 checks passed
@PhongChuong PhongChuong deleted the universeDomain branch February 29, 2024 19:27
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 6, 2024
🤖 I have created a release *beep* *boop*
---


## [3.3.0](https://togithub.com/googleapis/java-bigquerystorage/compare/v3.2.0...v3.3.0) (2024-03-04)


### Features

* Add RetrySettings use to Write API samples. ([#2419](https://togithub.com/googleapis/java-bigquerystorage/issues/2419)) ([5b000d0](https://togithub.com/googleapis/java-bigquerystorage/commit/5b000d0a4e953649ca4e44bffd3ba25c288e70e4))
* Add the RANGE type to the google.cloud.bigquery.storage.v1.TableFieldSchema ([#2413](https://togithub.com/googleapis/java-bigquerystorage/issues/2413)) ([6aa92b5](https://togithub.com/googleapis/java-bigquerystorage/commit/6aa92b5d03eed548de9e89b0731707f92c373ce3))
* Next release from main branch is 2.48.0 ([#2420](https://togithub.com/googleapis/java-bigquerystorage/issues/2420)) ([2dd8efc](https://togithub.com/googleapis/java-bigquerystorage/commit/2dd8efc4a21f186c20e86304092d22fd574e822e))


### Bug Fixes

* Fix issue where Universe Domain is not correctly set. ([#2423](https://togithub.com/googleapis/java-bigquerystorage/issues/2423)) ([b7ebd73](https://togithub.com/googleapis/java-bigquerystorage/commit/b7ebd73754fe51a4835f676e429b95b80f8114a5))


### Dependencies

* Update dependency com.google.cloud:google-cloud-bigquery to v2.38.0 ([#2417](https://togithub.com/googleapis/java-bigquerystorage/issues/2417)) ([8184a0f](https://togithub.com/googleapis/java-bigquerystorage/commit/8184a0f74e98340fe62621957f3ac78ad70c9edb))
* Update dependency com.google.cloud:google-cloud-bigquery to v2.38.0 ([#2418](https://togithub.com/googleapis/java-bigquerystorage/issues/2418)) ([4d5eb73](https://togithub.com/googleapis/java-bigquerystorage/commit/4d5eb7343cdf5fd617a2da120642bfd678d58f94))
* Update dependency com.google.truth:truth to v1.4.1 ([#2412](https://togithub.com/googleapis/java-bigquerystorage/issues/2412)) ([c2dcb73](https://togithub.com/googleapis/java-bigquerystorage/commit/c2dcb73c54ad5dcb68ce18741efaf479298373e1))
* Update dependency com.google.truth:truth to v1.4.2 ([#2424](https://togithub.com/googleapis/java-bigquerystorage/issues/2424)) ([7a12de0](https://togithub.com/googleapis/java-bigquerystorage/commit/7a12de0ebc6a0a0f4bb438e3dcb36ee0759c0b94))
* Update dependency org.graalvm.buildtools:native-maven-plugin to v0.10.1 ([#2414](https://togithub.com/googleapis/java-bigquerystorage/issues/2414)) ([dfa8d53](https://togithub.com/googleapis/java-bigquerystorage/commit/dfa8d532e5e1a28d644fefed6650ca1a2481a3a3))
* Update dependency org.json:json to v20240303 ([#2426](https://togithub.com/googleapis/java-bigquerystorage/issues/2426)) ([2accca7](https://togithub.com/googleapis/java-bigquerystorage/commit/2accca72f2bd26c9a1cf1bd918961889b9ee3ace))


### Documentation

* Mark BigQueryWrite v1beta2 as deprecated ([#2421](https://togithub.com/googleapis/java-bigquerystorage/issues/2421)) ([07d98ab](https://togithub.com/googleapis/java-bigquerystorage/commit/07d98ab417ae9fd2f90aca4d6a1a3ff62ef0bc1d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setUniverseDomain does not change the universeDomain that the client connects to
2 participants