Handle Javascript-based navigation for iFrame player in WKWebView #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haoteng
approved these changes
Feb 4, 2021
The web iFrame embedded player uses Javascript "window.open" to open the URL for UI elements like the video title and YT logo. WKWebView ignores this navigation by default, so this CL adds the necessary logic to link to the YT main app.
todd-patterson
approved these changes
Feb 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The web iFrame embedded player may use Javascript to open the URL for some UI elements. WKWebView ignores this navigation by default, so this change adds the logic to link to the YT app.
Tested on iPhone 12 Simulator, iOS 14.4. Verified that tapping on the video title links you to YT app site on Safari. Would redirect you to the YT main app if it was installed on the device.