Fix pod lint warnings (#380)

Fixed warnings about incorrect tags in documentation, version of iOS that the project was using (in both podspec and Xcode), and deprecated methods.
youtube · Jun 4, 2020 · 51230df · 51230df
1 parent f278335
commit 51230df
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/Classes/YTPlayerView.m b/Classes/YTPlayerView.m
@@ -689,7 +689,9 @@ - (BOOL)handleHttpNavigationToUrl:(NSURL *) url {
  if (ytMatch || adMatch || oauthMatch || staticProxyMatch || syndicationMatch) {
  return YES;
  } else {
- [[UIApplication sharedApplication] openURL:url];
+ [[UIApplication sharedApplication] openURL:url
+ options:@{UIApplicationOpenURLOptionUniversalLinksOnly: @NO}
+ completionHandler:nil];
  return NO;
  }
 }
@@ -800,7 +802,6 @@ - (BOOL)loadWithPlayerParams:(NSDictionary *)additionalPlayerParams {
  * video IDs to play with the playlist player.
  * @param index 0-index position of video to start playback on.
  * @param startSeconds Seconds after start of video to begin playback.
- * @return The result of cueing the playlist.
  */
 - (void)cuePlaylist:(NSString *)cueingString
  index:(int)index
@@ -820,7 +821,6 @@ - (void)cuePlaylist:(NSString *)cueingString
  * video IDs to play with the playlist player.
  * @param index 0-index position of video to start playback on.
  * @param startSeconds Seconds after start of video to begin playback.
- * @return The result of cueing the playlist.
  */
 - (void)loadPlaylist:(NSString *)cueingString
  index:(int)index

diff --git a/youtube-ios-player-helper.podspec b/youtube-ios-player-helper.podspec
@@ -43,7 +43,7 @@ Pod::Spec.new do |s|
  s.social_media_url = "https://twitter.com/YouTubeDev"
  s.source = { :git => "https://github.com/youtube/youtube-ios-player-helper.git", :tag => "0.1.6" }
 
- s.platform = :ios, '6.0'
+ s.platform = :ios, '10.0'
  s.requires_arc = true
 
  s.source_files = 'Classes'

diff --git a/youtube-ios-player-helper.xcodeproj/project.pbxproj b/youtube-ios-player-helper.xcodeproj/project.pbxproj
@@ -113,6 +113,7 @@
  developmentRegion = English;
  hasScannedForEncodings = 0;
  knownRegions = (
+ English,
  en,
  );
  mainGroup = B3C76A101B975AA700F375B4;
@@ -185,7 +186,7 @@
  GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
  GCC_WARN_UNUSED_FUNCTION = YES;
  GCC_WARN_UNUSED_VARIABLE = YES;
- IPHONEOS_DEPLOYMENT_TARGET = 9.0;
+ IPHONEOS_DEPLOYMENT_TARGET = 10.0;
  MTL_ENABLE_DEBUG_INFO = YES;
  ONLY_ACTIVE_ARCH = YES;
  SDKROOT = iphoneos;
@@ -226,7 +227,7 @@
  GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
  GCC_WARN_UNUSED_FUNCTION = YES;
  GCC_WARN_UNUSED_VARIABLE = YES;
- IPHONEOS_DEPLOYMENT_TARGET = 9.0;
+ IPHONEOS_DEPLOYMENT_TARGET = 10.0;
  MTL_ENABLE_DEBUG_INFO = NO;
  SDKROOT = iphoneos;
  TARGETED_DEVICE_FAMILY = "1,2";