Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates #227

Merged
merged 4 commits into from
Oct 7, 2019
Merged

Minor updates #227

merged 4 commits into from
Oct 7, 2019

Conversation

smaeda-ks
Copy link
Contributor

@smaeda-ks smaeda-ks commented Sep 16, 2019 •
edited

Change

  • Move Analytics class from the resource.py to the new analytics.py since it's just doesn't make sense at all to keep it in there.
    User Impact: For those who historically imported Analytics class from resource.py need to change import path:
- from twitter_ads.resouce import Analytics
+ from twitter_ads.analytics import Analytics

Add

  • LineItemApps - doc
  • LineItemPlacements - doc
  • ContentCategories - doc
  • IabCategories - doc

Documentation

  • Add more general usage code comments as much as possible... (aligning with Sphinx style)

@smaeda-ks smaeda-ks changed the title [WIP] General updates [WIP] Minor updates Sep 16, 2019
@smaeda-ks smaeda-ks self-assigned this Sep 16, 2019
@smaeda-ks smaeda-ks mentioned this pull request Sep 17, 2019
Merged
tushdante
tushdante approved these changes Sep 18, 2019
View reviewed changes
Copy link
Collaborator

@tushdante tushdante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smaeda-ks smaeda-ks changed the title [WIP] Minor updates Minor updates Oct 7, 2019
@smaeda-ks smaeda-ks merged commit 598e86c into xdevplatform:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tushdante tushdante tushdante approved these changes

Assignees

@smaeda-ks smaeda-ks

Labels
documentation improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaeda-ks @tushdante