Remove deprecated sentiment targeting (#247)

* Remove deprecated sentiment targeting * update fixtures
xdevplatform · Jan 28, 2020 · dd9adf2 · dd9adf2
1 parent 1350f9b
commit dd9adf2
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 12 deletions.
diff --git a/tests/fixtures/line_items_all.json b/tests/fixtures/line_items_all.json
@@ -29,7 +29,6 @@
  "currency": "USD",
  "created_at": "2011-07-11T20:36:11Z",
  "updated_at": "2011-09-04T19:39:51Z",
- "include_sentiment": null,
  "campaign_id": "2wap7",
  "deleted": false
  },
@@ -57,7 +56,6 @@
  "currency": "USD",
  "created_at": "2011-07-13T20:56:39Z",
  "updated_at": "2011-09-04T19:39:04Z",
- "include_sentiment": null,
  "campaign_id": "2wamv",
  "deleted": false
  },
@@ -85,7 +83,6 @@
  "currency": "USD",
  "created_at": "2011-07-14T00:04:47Z",
  "updated_at": "2011-09-04T19:39:39Z",
- "include_sentiment": null,
  "campaign_id": "2wai9",
  "deleted": false
  },
@@ -113,7 +110,6 @@
  "currency": "USD",
  "created_at": "2011-08-22T22:42:18Z",
  "updated_at": "2011-09-04T19:40:02Z",
- "include_sentiment": null,
  "campaign_id": "2of1n",
  "deleted": false
  },
@@ -141,7 +137,6 @@
  "currency": "JPY",
  "created_at": "2011-08-26T20:51:14Z",
  "updated_at": "2011-08-26T21:30:25Z",
- "include_sentiment": "POSITIVE_ONLY",
  "campaign_id": "2w9n1",
  "deleted": true
  },
@@ -169,7 +164,6 @@
  "currency": "USD",
  "created_at": "2011-08-26T21:38:51Z",
  "updated_at": "2011-08-26T22:24:37Z",
- "include_sentiment": "POSITIVE_ONLY",
  "campaign_id": "2vuug",
  "deleted": true
  },
@@ -197,7 +191,6 @@
  "currency": "JPY",
  "created_at": "2011-08-26T22:28:55Z",
  "updated_at": "2011-09-04T19:38:46Z",
- "include_sentiment": null,
  "campaign_id": "2vuj3",
  "deleted": false
  },
@@ -225,7 +218,6 @@
  "currency": "USD",
  "created_at": "2011-09-01T17:25:04Z",
  "updated_at": "2011-09-16T02:56:55Z",
- "include_sentiment": null,
  "campaign_id": "2v3c4",
  "deleted": true
  },
@@ -253,7 +245,6 @@
  "currency": "JPY",
  "created_at": "2011-09-06T17:42:52Z",
  "updated_at": "2011-09-30T18:54:18Z",
- "include_sentiment": null,
  "campaign_id": "2ttv3",
  "deleted": false
  },
@@ -281,7 +272,6 @@
  "currency": "USD",
  "created_at": "2011-09-06T22:44:13Z",
  "updated_at": "2011-09-20T01:32:27Z",
- "include_sentiment": null,
  "campaign_id": "2ttv3",
  "deleted": true
  }

diff --git a/tests/fixtures/line_items_load.json b/tests/fixtures/line_items_load.json
@@ -24,7 +24,6 @@
  "currency": "USD",
  "created_at": "2011-07-11T20:36:11Z",
  "updated_at": "2011-09-04T19:39:51Z",
- "include_sentiment": null,
  "campaign_id": "2wap7",
  "deleted": false
  },

diff --git a/twitter_ads/campaign.py b/twitter_ads/campaign.py
@@ -298,7 +298,6 @@ def save(self):
 resource_property(LineItem, 'charge_by')
 resource_property(LineItem, 'end_time', transform=TRANSFORM.TIME)
 resource_property(LineItem, 'entity_status')
-resource_property(LineItem, 'include_sentiment')
 resource_property(LineItem, 'audience_expansion')
 resource_property(LineItem, 'name')
 resource_property(LineItem, 'objective')