Add <link disabled> #4519

annevk · 2019-04-10T10:15:42Z

Fixes #3840, maybe.

/custom-elements.html ( diff )
/indices.html ( diff )
/links.html ( diff )
/semantics.html ( diff )

annevk

@emilio here's a sketch, but I've mainly identified the places that need changing and did not thoroughly think through what needs to happen in each place.

source

annevk · 2019-04-10T10:17:50Z

source

@@ -24936,7 +24947,8 @@ document.body.appendChild(wbr);</code></pre>
 <dd><p>null</p></dd>

 <dt><span data-x="concept-css-style-sheet-disabeld-flag">disabled flag</span></dt>
- <dd><p>Left at its default value.</p></dd>
+ <dd><p>Unset if <var>element</var>'s <span>explicitly enabled</span> is true, and left at its
+ default value otherwise.</p></dd>


This also doesn't seem entirely correct.

Yes, I need to add a new flag to CSSOM instead.

sideshowbarker · 2019-04-13T07:19:57Z

heads-up @whatwg/documentation

chrisdavidmills · 2019-04-15T10:28:16Z

Potential documentation need recorded at https://trello.com/c/6YAMGL3B/132-html-link-element

Tests: ... Fixes #3840, maybe.

For whatwg/html#4519.

annevk · 2020-04-20T14:39:56Z

I filed w3c/csswg-drafts#4978 as a follow-up here.

If the current PR looks good I suggest we merge it next week somewhere to give some time for final concerns.

domenic · 2020-04-20T14:42:41Z

I'm sad to ask, but is there multi-implementer interest here?

annevk · 2020-04-20T14:46:08Z

Is your question specifically about #3840 (comment)? It would be good to hear from @mfreed7 and @cdumez, yeah.

domenic · 2020-04-20T15:00:07Z

It was more general, but it sounds like you have done the work of narrowing it down to specific divergences, which is even better. In particular it sounds like for 001/002, if we wanted to go with the majority we'd have some different (probably worse) behavior than what is in this PR. But if we want to go with what's in this PR, then we should get at least one of Chrome and Safari to agree to change.

emilio · 2020-04-22T20:12:43Z

cc @lilles, is fixing this in Chromium something you'd consider? Current alternate sheets are pretty broken there :)

domenic

LGTM with potential improvement

domenic · 2020-05-28T14:07:13Z

source

+ <p>Removing the <code data-x="attr-link-disabled">disabled</code> attribute dynamically will
+ fetch and apply the style sheet:</p>
+
+ <pre><code class="html" data-x="">&lt;link disabled rel="alternate stylesheet" href="css/pooh"></code></pre>


This example should probably include script that removes the disabled attribute.

You mean adding <script>document.querySelector("link").removeAttribute("disabled")</script>? Seems a bit redundant to me.

Yeah, exactly. Right now the intro text for the example seems pretty disconnected from the example itself; it talks about removing but the code under discussion does nothing of the sort.

For whatwg/html#4519.

annevk · 2020-05-29T09:38:53Z

Filed https://bugs.webkit.org/show_bug.cgi?id=212515 on WebKit. Chrome already has an intent to ship out so I think that's covered.

…estonly Automatic update from web-platform-tests <link disabled> is now standardized For whatwg/html#4519. -- wpt-commits: ee42c2ebaba97d3bb6b4676de3712f62a6eea1d9 wpt-pr: 22645

Previously, Chromium had intermittent behavior with respect to the "disabled" attribute: - <link id=foo rel="stylesheet" disabled> would not show up in document.styleSheets. - foo.disabled=false; foo.disabled=true; would cause it to appear (and remain) in document.styleSheets. - <link rel="alternate stylesheet"> cannot be enabled, except by disabling and re-enabling it. - When disabled, link.ownerNode was not null The above issues are being resolved with this CL. See the spec discussion and PR here: whatwg/html#3840 whatwg/html#4519 And the ChromeStatus and I2S here: https://chromestatus.com/feature/5110851973414912 https://groups.google.com/a/chromium.org/d/msg/blink-dev/3izM5vVo98U/iDLjz_TwAgAJ= WPT tests are located here: https://wpt.fyi/results/css/cssom?label=master&label=experimental&aligned&q=htmllinkelement-disabled and they show that Firefox already implements the new behavior, while WebKit does not. With this CL, all 7 tests are now green. Bug: 695984, 1087043 Change-Id: Ic6d2c8e901a72885b9f4806c616adb95e019cf09 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216701 Reviewed-by: Chris Harrelson <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Commit-Position: refs/heads/master@{#774658}

sideshowbarker · 2020-06-04T00:55:38Z

As far as the doc need, https://developer.mozilla.org/en-US/docs/Web/HTML/Element/link#attr-disabled already has documentation for this. But it’d be great to have it reviewed. If anybody has changes, you can edit that article directly, or else let me know and I’d be happy to make any changes needed.

mfreed7 · 2020-06-04T03:48:56Z

@sideshowbarker, the documentation looks pretty good, except this part:

Changing the value of this property instead simply enables and disables the stylesheet form being applied to the document.
This differs from StyleSheet's disabled property; changing it to true removes the stylesheet from the document's document.styleSheets list, ...

The difference/change is that now, changing HTMLLinkElement.disabled to true will actually remove the stylesheet from document.styleSheets.

sideshowbarker · 2020-06-04T04:54:05Z

@mfreed7 OK, thanks — so I’ve replaced the text cited above with the following single sentence:

Setting the disabled property in the DOM causes the stylesheet to be removed from the document's document.styleSheets list.

Lemme know if further changes are needed.

mfreed7 · 2020-06-05T07:25:37Z

Sounds succinct and correct - thanks!

All browsers have implemented this for a long time. (However, unlike HTMLLinkElement, no browsers implement a disabled="" content attribute for <style>.) Note that this was originally tracked by #1081. That issue was closed in #4519, though it did not spec anything <style> related.

All browsers have implemented this for a long time. (However, unlike HTMLLinkElement, no browsers implement a disabled="" content attribute for <style>.) Note that this was originally tracked by whatwg#1081. That issue was closed in whatwg#4519, though it did not spec anything <style> related.

Previously, Chromium had intermittent behavior with respect to the "disabled" attribute: - <link id=foo rel="stylesheet" disabled> would not show up in document.styleSheets. - foo.disabled=false; foo.disabled=true; would cause it to appear (and remain) in document.styleSheets. - <link rel="alternate stylesheet"> cannot be enabled, except by disabling and re-enabling it. - When disabled, link.ownerNode was not null The above issues are being resolved with this CL. See the spec discussion and PR here: whatwg/html#3840 whatwg/html#4519 And the ChromeStatus and I2S here: https://chromestatus.com/feature/5110851973414912 https://groups.google.com/a/chromium.org/d/msg/blink-dev/3izM5vVo98U/iDLjz_TwAgAJ= WPT tests are located here: https://wpt.fyi/results/css/cssom?label=master&label=experimental&aligned&q=htmllinkelement-disabled and they show that Firefox already implements the new behavior, while WebKit does not. With this CL, all 7 tests are now green. Bug: 695984, 1087043 Change-Id: Ic6d2c8e901a72885b9f4806c616adb95e019cf09 Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216701 Reviewed-by: Chris Harrelson <[email protected]> Reviewed-by: Rune Lillesveen <[email protected]> Commit-Queue: Mason Freed <[email protected]> Cr-Original-Commit-Position: refs/heads/master@{#774658} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 0ebaa77c4ffda85933b6a822218e1c4b439efbe9

annevk commented Apr 10, 2019

View reviewed changes

sideshowbarker added the impacts documentation Used by documentation communities, such as MDN, to track changes that impact documentation label Apr 13, 2019

Add <link disabled>

de4720d

Tests: ... Fixes #3840, maybe.

annevk force-pushed the annevk/attr-link-disabled branch from 79c033d to de4720d Compare April 2, 2020 10:30

nits

c5effff

annevk added a commit to web-platform-tests/wpt that referenced this pull request Apr 2, 2020

<link disabled> is now standardized

115a245

For whatwg/html#4519.

This was referenced Apr 2, 2020

<link disabled> is now standardized web-platform-tests/wpt#22645

Merged

<link rel="stylesheet" disabled> #3840

Closed

sideshowbarker approved these changes Apr 13, 2020

View reviewed changes

use suggestion from emilio

5fac8a6

emilio approved these changes Apr 22, 2020

View reviewed changes

annevk added needs implementer interest Moving the issue forward requires implementers to express interest do not merge yet Pull request must not be merged per rationale in comment labels May 27, 2020

domenic removed do not merge yet Pull request must not be merged per rationale in comment needs implementer interest Moving the issue forward requires implementers to express interest labels May 28, 2020

domenic approved these changes May 28, 2020

View reviewed changes

add some JS to the example

d5a1e3f

annevk merged commit 9e77887 into master May 29, 2020

annevk deleted the annevk/attr-link-disabled branch May 29, 2020 06:17

annevk added a commit to web-platform-tests/wpt that referenced this pull request May 29, 2020

<link disabled> is now standardized

ee42c2e

For whatwg/html#4519.

mfreed7 mentioned this pull request May 29, 2020

Behavior of the "disabled" attribute for HTMLLinkElement w3ctag/design-reviews#519

Closed

1 task

CYBAI mentioned this pull request Jun 1, 2020

Implement <link disabled> servo/servo#26739

Open

ssddanbrown mentioned this pull request Oct 24, 2021

jQuery Requesting Fonts (and Failing to Retrieve Them) GlennHS/Scrum-Helper#30

Closed

domfarolino mentioned this pull request Apr 4, 2022

Add <style>'s disabled IDL attribute #7779

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add <link disabled> #4519

Add <link disabled> #4519

annevk commented Apr 10, 2019 •

edited by pr-preview bot

annevk left a comment

annevk Apr 10, 2019

emilio Apr 10, 2019

sideshowbarker commented Apr 13, 2019

chrisdavidmills commented Apr 15, 2019

annevk commented Apr 20, 2020

domenic commented Apr 20, 2020

annevk commented Apr 20, 2020

domenic commented Apr 20, 2020

emilio commented Apr 22, 2020

domenic left a comment

domenic May 28, 2020

annevk May 28, 2020

domenic May 28, 2020

annevk commented May 29, 2020

sideshowbarker commented Jun 4, 2020

mfreed7 commented Jun 4, 2020

sideshowbarker commented Jun 4, 2020

mfreed7 commented Jun 5, 2020

Add <link disabled> #4519

Add <link disabled> #4519

Conversation

annevk commented Apr 10, 2019 • edited by pr-preview bot

annevk left a comment

Choose a reason for hiding this comment

annevk Apr 10, 2019

Choose a reason for hiding this comment

emilio Apr 10, 2019

Choose a reason for hiding this comment

sideshowbarker commented Apr 13, 2019

chrisdavidmills commented Apr 15, 2019

annevk commented Apr 20, 2020

domenic commented Apr 20, 2020

annevk commented Apr 20, 2020

domenic commented Apr 20, 2020

emilio commented Apr 22, 2020

domenic left a comment

Choose a reason for hiding this comment

domenic May 28, 2020

Choose a reason for hiding this comment

annevk May 28, 2020

Choose a reason for hiding this comment

domenic May 28, 2020

Choose a reason for hiding this comment

annevk commented May 29, 2020

sideshowbarker commented Jun 4, 2020

mfreed7 commented Jun 4, 2020

sideshowbarker commented Jun 4, 2020

mfreed7 commented Jun 5, 2020

annevk commented Apr 10, 2019 •

edited by pr-preview bot