Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fine-grained errors reporting for PaymentAddress #712

Merged
merged 2 commits into from
Jun 6, 2018
Merged

fine-grained errors reporting for PaymentAddress #712

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3350316
fine-grained error reporting for PaymentAddress
marcoscaceres May 16, 2018
a9aee3f
review feedback
marcoscaceres Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
review feedback
  • Loading branch information
@marcoscaceres
marcoscaceres committed Jun 6, 2018
commit a9aee3f07d0438b5b436320e6f861c8873fc5bde
9 changes: 5 additions & 4 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2770,10 +2770,11 @@ <h2>
<p>
The members of the <a>AddressErrorFields</a> dictionary represent
validation errors with specific parts of a <a>physical address</a>.
Each dictionary member has a dual function: firstly, it denotes that
a particular part of an address is suffering from a validation error.
Secondly, the string value allows the developer to describe the
validation error (and possibly how the end user can fix the error).
Each dictionary member has a dual function: firstly, its presence
denotes that a particular part of an address is suffering from a
validation error. Secondly, the string value allows the developer to
describe the validation error (and possibly how the end user can fix
the error).
</p>
<p class="note">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kept this (languageCodeError) for completeness... but wonder if we should just ditch languageCodeError. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified what "this" was above.

Developers need to be aware that users might not have the ability to
Expand Down