Have deviceId follow partitioning rules for storage (such as localStorage) #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
I think this is reasonable for now. Long term all APIs should build on to-be-defined primitives in https://storage.spec.whatwg.org/ that would give some space to store things.
Iframes that are of the same origin won't have a different partition though as they could just reach the top via script.
|
Can we refer to https://storage.spec.whatwg.org/ directly then? |
|
We should, but it looks like doing so is blocked on whatwg/storage#18, so I think we should merge this for now and open an issue to come back to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #598. @annevk PTAL.