Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer display-mode to mediaqueries-5 #1022

Merged
merged 1 commit into from
Dec 18, 2021
Merged

Transfer display-mode to mediaqueries-5 #1022

merged 1 commit into from
Dec 18, 2021

Conversation

frivoal
Copy link
Contributor

@frivoal frivoal commented Dec 3, 2021 •
edited by pr-preview bot

Closes w3c/csswg-drafts#6343

This change:

  • Makes editorial changes (changes informative sections, or changes normative sections without changing behavior)

(More specifically, it move existing definitions and functionality to a different specification, along with some editorial tweaks to better fit the new context, without changing the behavior)

This should not be merged until Mediaqueries-5 has been republished on /TR with display-mode included (see w3c/csswg-drafts#6343).

Commit message:

Transfer display-mode to mediaqueries-5

See https://github.com/w3c/csswg-drafts/issues/6343 and
https://github.com/w3c/manifest/issues/975#issuecomment-853456738

Person merging, please make sure that commits are squashed with one of the following as a commit message prefix:

  • chore:
  • editorial:
  • BREAKING CHANGE:
  • And use none if it's a normative change

Preview | Diff

@frivoal
Copy link
Contributor Author

frivoal commented Dec 4, 2021

ipr — PR has contribution issues. The following users were not in the repository's groups: @frivoal

This PR removes text from here (and places it into a different spec), so I suspect you can accept it without risk despite the fact that I am not a member of the WG, but if you'd like me to sign some IPR agreement (or to join the WG as an IE), that's fine. Just let me know. cc @wseltzer

@wseltzer
Copy link
Member

wseltzer commented Dec 6, 2021

@frivoal If you're willing to sign the IP commitment (sent to you via email), that's the clearest way of handling it. Thanks!

@frivoal
Copy link
Contributor Author

frivoal commented Dec 6, 2021

If you're willing to sign the IP commitment (sent to you via email)

Done

marcoscaceres
marcoscaceres approved these changes Dec 7, 2021
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@marcoscaceres marcoscaceres added the BLOCKED Blocked for some reason label Dec 7, 2021
@marcoscaceres
Copy link
Member

marcoscaceres commented Dec 7, 2021 •
edited

IPR bot seems happy. Blocking merge until Mediaqueries-5 has been republished on /TR.

@frivoal, ping us whenever you are ready for this to land.

@frivoal
Copy link
Contributor Author

frivoal commented Dec 18, 2021

Blocking merge until Mediaqueries-5 has been republished on /TR.

This has now happened (https://www.w3.org/TR/mediaqueries-5/#display-modes), so the PR can be landed.

Issues filed while preparing this PR (#1023 and #1024) should still be addressed, but we're no worse off than before the transfer from one spec to the other, so which spec the feature is in while it gets fixed is not especially important.

@marcoscaceres marcoscaceres merged commit 874996c into w3c:gh-pages Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
BLOCKED Blocked for some reason
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[mediaqueries] display mode media feature
3 participants
@frivoal @wseltzer @marcoscaceres