Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic check to find duplicate option in the command. #667

Open
wants to merge 3 commits into
base: unstable
Choose a base branch
from

Conversation

Shivshankar-Reddy
Copy link
Contributor

@Shivshankar-Reddy Shivshankar-Reddy commented Jun 18, 2024

This fixes #571 .

Added a generic check in processCommand as similar to arity check.
Will close #602 as it focuses on only few commands.

Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: Shivshankar-Reddy <[email protected]>
@Shivshankar-Reddy Shivshankar-Reddy marked this pull request as draft June 18, 2024 20:09
Signed-off-by: Shivshankar-Reddy <[email protected]>
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 84.84848% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.26%. Comparing base (be2c321) to head (595fad6).

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #667      +/-   ##
============================================
+ Coverage     70.21%   70.26%   +0.05%     
============================================
  Files           110      110              
  Lines         60069    60102      +33     
============================================
+ Hits          42175    42231      +56     
+ Misses        17894    17871      -23     
Files Coverage Δ
src/server.c 88.50% <84.84%> (-0.04%) ⬇️

... and 9 files with indirect coverage changes

@Shivshankar-Reddy Shivshankar-Reddy marked this pull request as ready for review June 18, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Duplicated arguments are accepted in ZINTER, ZUNION, and ZDIFF command
1 participant