Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kr/pty dependency #2925

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Remove kr/pty dependency #2925

merged 2 commits into from
Feb 20, 2024

Conversation

hugelgupf
Copy link
Member

@hugelgupf hugelgupf commented Feb 20, 2024

Fixes #2682

Signed-off-by: Chris Koch <[email protected]>
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (abb467f) 77.97% compared to head (0a712e7) 77.97%.

❗ Current head 0a712e7 differs from pull request most recent head 6cee1cc. Consider uploading reports for the commit 6cee1cc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2925   +/-   ##
=======================================
  Coverage   77.97%   77.97%           
=======================================
  Files         430      430           
  Lines       43153    43153           
=======================================
  Hits        33649    33649           
  Misses       9504     9504           
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 70.48% <ø> (+0.03%) ⬆️
integration/generic-tests/...-amd64 20.41% <ø> (ø)
integration/generic-tests/...-arm 11.74% <ø> (ø)
integration/generic-tests/...-arm64 23.74% <ø> (ø)
integration/gotests/...-amd64 74.47% <ø> (-0.01%) ⬇️
integration/gotests/...-arm 75.80% <ø> (ø)
integration/gotests/...-arm64 75.77% <ø> (+0.07%) ⬆️
pkg/...-amd64 76.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hugelgupf hugelgupf added the Awaiting reviewer Waiting for a reviewer. label Feb 20, 2024
@hugelgupf hugelgupf enabled auto-merge (rebase) February 20, 2024 04:52
@hugelgupf hugelgupf merged commit 27539e2 into u-root:main Feb 20, 2024
22 checks passed
@hugelgupf hugelgupf deleted the pty branch February 20, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting reviewer Waiting for a reviewer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

github.com/kr/pty has been replaced, use github.com/creack/pty instead
2 participants