Migrate code from PyQt5 to PySide6 #720
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR and for working on the Qt6 support! If possible, please submit your changes here instead. The GitHub repo is just a mirror. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request aims to migrate torbrowser-launcher from
Qt5toQt6.The next step is to update deps in
BUILD.md,build_rpm.sh, andstdeb.cfgto installpython3-pyside6rather thanpython3-pyqt5. But for the time beeping, Debian doesn't shippyside6in there repos and so does Fedora.By the way according to my knowledge, torbrowser-launcher is currently violating PyQt5's
GPLv3license by being licensed underMIT(unless the commercial license is used). So we must usePySide6or chagne torbrowser-launcher's license to GPLv3.Should we just don't care about GPLv3, FOSS, and official support and use
PyQt6rather thanPySide6sincePyQt6is already available in Debian Bookworm and Fedora?