Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug31571 041 #1452

Open
wants to merge 6 commits into
base: maint-0.4.1
Choose a base branch
from
Open

Bug31571 041 #1452

wants to merge 6 commits into from

Conversation

teor2345
Copy link
Contributor

No description provided.

We want to report the tor version, even on platforms that don't have
backtrace support (like Android).

This commit stores the backtrace Tor version, regardless of USE_BACKTRACE.

Preparation for 31571.
Previously, we just logged it in the crash handler.

Part of 31571.
…ation

Some platforms (macOS, maybe others?) can swallow the last write before an
abort. This issue is probably caused by a race condition between write
buffer cache flushing, and process termination. So we write an extra
newline, to make sure that the message always gets through.

Fixes bug 31571; bugfix on 0.3.5.1-alpha.
We can't use strlcat() or strlcpy() in torerr, because they are defined
in string/compat_string.h on some platforms, and string uses torerr.

Part of 31571.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6870

  • 11 of 15 (73.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 62.626%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/err/backtrace.c 11 13 84.62%
src/lib/err/torerr.c 0 2 0.0%
Totals Coverage Status
Change from base Build 6863: 0.001%
Covered Lines: 46975
Relevant Lines: 75009

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants