Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better UI for index page in the embedded web server #226

Merged
merged 2 commits into from
Sep 2, 2022
Merged

Better UI for index page in the embedded web server #226

merged 2 commits into from
Sep 2, 2022

Conversation

nivoc
Copy link
Contributor

@nivoc nivoc commented Aug 26, 2022

Possible Simple Layout

@nivoc
UI
2318e14 
Possible Simple Layout
kasperl
kasperl reviewed Aug 27, 2022
View reviewed changes
Copy link
Member

@kasperl kasperl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this! Here are a few comments:

src/jaguar.toit Outdated Show resolved Hide resolved
src/jaguar.toit Outdated Show resolved Hide resolved
src/jaguar.toit Outdated Show resolved Hide resolved
src/jaguar.toit Outdated Show resolved Hide resolved
src/jaguar.toit Outdated Show resolved Hide resolved
src/jaguar.toit Show resolved Hide resolved
src/jaguar.toit Show resolved Hide resolved
src/jaguar.toit Outdated Show resolved Hide resolved
src/jaguar.toit Outdated Show resolved Hide resolved
src/jaguar.toit Outdated Show resolved Hide resolved
@kasperl kasperl changed the title UI Better UI for index page in the embedded web server Aug 27, 2022
@nivoc
Worked in all the comments
75986fc 
 * Seperated style.css
 * Fixed indentation
 * Fixed mixed spaces/tabs
 * Improved visuals
@nivoc
Copy link
Contributor Author

nivoc commented Aug 30, 2022 •
edited

Sry for the delay. I was knocked out for 2 days. I worked in the comments and improved the layout a bit.
image

@erikcorry erikcorry merged commit 85205ff into toitlang:main Sep 2, 2022
@erikcorry
Copy link
Member

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperl kasperl kasperl left review comments

@erikcorry erikcorry erikcorry approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nivoc @erikcorry @kasperl