Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): add documentation button in help menu bar #7199

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

yujioshiro
Copy link
Contributor

Fixes #7060

Changes were made to the Help button in the menu bar so that users can be taken directly to the Documentation instead of navigating to it manually if they wish to seek help.

Copy link

graphite-app bot commented Jun 12, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@CLAassistant
Copy link

CLAassistant commented Jun 12, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ pengx17
❌ yujioshiro
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added the app:electron Related to electron app label Jun 12, 2024
Copy link

nx-cloud bot commented Jun 12, 2024

@EYHN EYHN requested a review from pengx17 June 12, 2024 07:26
@EYHN EYHN changed the title Add documentation button in Help menu bar feat(electron): add documentation button in help menu bar Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.63%. Comparing base (e14e110) to head (5fd645f).

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #7199      +/-   ##
==========================================
+ Coverage   62.58%   62.63%   +0.05%     
==========================================
  Files         794      794              
  Lines       35680    35680              
  Branches     3520     3521       +1     
==========================================
+ Hits        22329    22347      +18     
+ Misses      13069    13051      -18     
  Partials      282      282              
Flag Coverage Δ
server-test 78.50% <ø> (+0.07%) ⬆️
unittest 31.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Jun 17, 2024

Merge activity

  • Jun 17, 8:59 AM EDT: pengx17 added this pull request to the Graphite merge queue.
  • Jun 17, 8:59 AM EDT: The Graphite merge queue wasn't able to merge this pull request due to Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge.

@pengx17 pengx17 merged commit e3bd856 into toeverything:canary Jun 17, 2024
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

​No easy way to open documentation from the Mac app
3 participants