Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing substitution of propagated workspace in WorkingDirs #8008

Closed
chitrangpatel opened this issue May 30, 2024 · 0 comments · Fixed by #8016
Closed

Missing substitution of propagated workspace in WorkingDirs #8008

chitrangpatel opened this issue May 30, 2024 · 0 comments · Fixed by #8016
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@chitrangpatel
Copy link
Member

Expected Behavior

apiVersion: tekton.dev/v1
kind: PipelineRun
metadata:
  name: ws-1
spec:
  workspaces:
  - name: "default-workspace"
    volumeClaimTemplate:
      spec:
        accessModes:
         - ReadWriteOnce
        resources:
          requests:
            storage: 1Gi
  pipelineSpec:
    tasks:
    - name: "write-sth"
      taskSpec:
        steps:
          - image: "ubuntu"
            script: |
              #!/bin/bash
              cd "$(workspaces.default-workspace.path)"
              mkdir -p backend/app
              ls -tlr
    - name: "get-it"
      taskSpec:
        steps:
          - image: "ubuntu"
            workingDir: $(workspaces.default-workspace.path)/backend/app
            script: |
              pwd
              echo done

The abovePipelineRun should run well and replace $(workspaces.default-workspace.path) with /workspace/default-workspace in the workingDir of the step because of workspace propagation.

Actual Behavior

The substitution is not applied and the container fails with the error message that the workingDir must be an absolute path. However, the same works in a Taskrun.

Steps to Reproduce the Problem

  1. Execute the above pipelinerun in any of the recent Tekton Pipelines releases.

Additional Info

  • Kubernetes version:

    Output of kubectl version:

(paste your output here)

  • Tekton Pipeline version:

    Output of tkn version or kubectl get pods -n tekton-pipelines -l app=tekton-pipelines-controller -o=jsonpath='{.items[0].metadata.labels.version}'

(paste your output here)
@chitrangpatel chitrangpatel added the kind/bug Categorizes issue or PR as related to a bug. label May 30, 2024
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 4, 2024
@chitrangpatel
Fix: Identify workspace usage in a Task
3c9a1fd 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.
@chitrangpatel chitrangpatel mentioned this issue Jun 4, 2024
Merged
8 tasks
tekton-robot pushed a commit that referenced this issue Jun 4, 2024
@chitrangpatel @tekton-robot
Fix: Identify workspace usage in a Task
7ac2ca6 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes #8008.
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this issue Jun 4, 2024
@chitrangpatel
Fix: Identify workspace usage in a Task
b0a4dae 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this issue Jun 4, 2024
@chitrangpatel
Fix: Identify workspace usage in a Task
94def03 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this issue Jun 4, 2024
@chitrangpatel
Fix: Identify workspace usage in a Task
d8bec3c 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.
tekton-robot pushed a commit that referenced this issue Jun 4, 2024
@chitrangpatel @tekton-robot
Fix: Identify workspace usage in a Task
9220a12 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes #8008.
tekton-robot pushed a commit that referenced this issue Jun 4, 2024
@chitrangpatel @tekton-robot
Fix: Identify workspace usage in a Task
8a7ccf4 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes #8008.
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 4, 2024
@chitrangpatel
Fix: Identify workspace usage in a Task
3d3b942 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 4, 2024
@chitrangpatel
Manual cherry-pick to avoid conflict with step-params
1393915 
Fix: Identify workspace usage in a Task

Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this issue Jun 4, 2024
@chitrangpatel
Fix: Identify workspace usage in a Task
91baace 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.
tekton-robot pushed a commit that referenced this issue Jun 4, 2024
@chitrangpatel @tekton-robot
Fix: Identify workspace usage in a Task
ee3af64 
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes #8008.
chitrangpatel added a commit to chitrangpatel/pipeline that referenced this issue Jun 5, 2024
@chitrangpatel
Fix: Identify workspace usage in a Task
2d70e8f 
Manual cherry-pick to avoid conflict with step-params.
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes tektoncd#8008.
tekton-robot pushed a commit that referenced this issue Jun 5, 2024
@chitrangpatel @tekton-robot
Fix: Identify workspace usage in a Task
40b1bbd 
Manual cherry-pick to avoid conflict with step-params.
Prior to this, when identifying whether a Task used a workspace,
we limited the check to command, args and scripts in steps,
stepTemplates and sidecars. However, the workspace path could also
be used as a param to a StepAction or env cariables in steps and
sidecars and also workingDirs. This PR fixes that.

Fixes #8008.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Identify workspace usage in a Task chitrangpatel/pipeline
1 participant
@chitrangpatel