android/ui: open login screen on toggle #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates tailscale/corp#20930 To address review concerns regarding the toggle being unresponsive with the d-pad. We'll now open the QR login screen on android TV if you toggle the VPN when we're in the NeedsLogin state. Signed-off-by: Jonathan Nobels <[email protected]>
1eb439f
to
1a115c6
Compare
agottardo
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates tailscale/corp#20930
To address review concerns regarding the toggle being unresponsive with the d-pad. We'll now open the QR login screen on android TV if you toggle the VPN when we're in the NeedsLogin state.