Skip to content

DOC add links to SVC vs Semi-Supervised example link to SVC subsection in "Mathematical formulation" in Support Vector Machines documentation #31499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

chibihime
Copy link

This PR adds a direct link to an example comparing SVC and semi-supervised classifiers on the IRIS dataset to improve visibility.

Changes were tested locally by building the documentation.

chibihime added 3 commits May 27, 2025 15:32
Added example link to Decision boundary of semi-supervised classifiers versus SVM on the Iris dataset
@chibihime chibihime changed the title Add SVC vs Semi-Supervised example link to SVC subsection in "Mathematical formulation" in Support Vector Machines documentation DOC add links to SVC vs Semi-Supervised example link to SVC subsection in "Mathematical formulation" in Support Vector Machines documentation Jun 6, 2025
Copy link

github-actions bot commented Jun 6, 2025

✔️ Linting Passed

All linting checks passed. Your pull request is in excellent shape! ☀️

Generated for commit: 4377afa. Link to the linter CI: here

@chibihime
Copy link
Author

ping @scikit-learn/documentation-team, @StefanieSenger

@StefanieSenger
Copy link
Contributor

Hi @chibihime,

thanks for your PR. I actually don't think we should add this link in doc/modules/svm.rst since the SVC in the example is only used as a reference point / base to show LabelSpreading and it's not an example of how to use SVC, (which we already have elsewhere, too).

I would suggest to close this PR therefore. I'm sorry, @chibihime, since issue #30621 is a real task that scikit-learn needs more hands and eyes to solve (not a mere practice issue for first contributions) the outcome can sometimes be that a reference it not needed.

I also think that this example is very similar to Semi-supervised Classification on a Text Dataset, which is currently re-worked in #31104. Is it maybe reasonable to remove this example (we're dealing with in this PR) entirely? What do you think, @adrinjalali?

@StefanieSenger
Copy link
Contributor

Feel very welcome to pick another example for a reference, @chibihime! ❤️

@adrinjalali
Copy link
Member

@StefanieSenger I'd be happy to remove this if we also make sure the message of this example is included in the other one. I agree it makes sense to have one example conveying the two messages.

@StefanieSenger
Copy link
Contributor

That's maybe something @elhambbi wants to take care of in a follow-up PR afterwards?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants