DOC Removed examples/semi_supervised/plot_semi_supervised_versus_svm_iris.py #31625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @StefanieSenger. I created this PR to remove the example mentioned in #31499 (this example is not referenced anywhere). |
There was a problem hiding this comment.
Hi @elhambbi, thanks for this PR to remove the example as we had discussed with @adrinjalali.
There are a few tasks that are left to be done:
- Remove the references to this example in
doc/modules/semi_supervised.rst(in currently li. 66 and in li. 139) - We need to add a redirection in
doc/conf.pyto the re-worked example in case the removed example had been linked externally. You can use #30906 as a guide of how to do that. - Could you shortly sum up, what are the interesting things from the deleted example, that you would like to integrate into your re-worked example in #31104? Are there any at all?
No worries about the failing CI checks, btw, they come from main and have nothing to do with your PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Removed the example
examples/semi_supervised/plot_semi_supervised_versus_svm_iris.pyas discussed in #31499What does this implement/fix? Explain your changes.
The performance of semi-supervised methods, SelfTraining and LabelSpreading, is already evaluated in this example, which is improved in #31104. There is no need for more examples to show this.
Any other comments?