Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix virt-install-ubuntu disk detection + size #8

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Fix virt-install-ubuntu disk detection + size #8

merged 1 commit into from
Aug 31, 2020

Conversation

TyKeeling
Copy link
Collaborator

I am not sure the second FIXME is necessary as it looks like the vol-upload will automatically change the capacity and allocation of an image after the vol-create-as.

For instance:

virsh vol-create-as default ${NAME}-seed.qcow2 512M --format qcow2
virsh vol-info --pool default stephen-seed.qcow2
virsh vol-upload --pool default ${NAME}-seed.qcow2 ${NAME}-seed.qcow2
virsh vol-info --pool default stephen-seed.qcow2

gives

Name:           stephen-seed.qcow2
Type:           file
Capacity:       64.00 KiB
Allocation:     196.00 KiB

Name:           stephen-seed.qcow2
Type:           file
Capacity:       368.00 KiB
Allocation:     368.00 KiB

Resolves problems mentioned in #7

sbates130272
sbates130272 requested changes Aug 31, 2020
View reviewed changes
libvirt/virt-install-ubuntu Show resolved Hide resolved
libvirt/virt-install-ubuntu Outdated
virsh vol-create-as default ${NAME}.qcow2 ${SIZE}G --format qcow2
virsh vol-upload --pool default ${NAME}.qcow2 ${NAME}.qcow2

virsh vol-delete --pool default ${NAME}-seed.qcow2
remove_vol ${NAME}-seed.qcow2
# FIXME: Detect size of seed disk image so we don't fix it at 512M.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line above this.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is resolved?

libvirt/virt-install-ubuntu Outdated Show resolved Hide resolved
@TyKeeling @sbates130272
virt-install-ubuntu: Fix focal disk detection
527e9c8 
Fix virt-install-ubuntu disk detection and size for focal

Resolves problems mentioned in:
#7
@sbates130272
Copy link
Owner

@TyKeeling thanks. I tidied up some indents and will merge.

@sbates130272 sbates130272 merged commit b270760 into master Aug 31, 2020
@sbates130272 sbates130272 deleted the tyler/virt-install-fixme branch August 31, 2020 21:36
@sbates130272 sbates130272 mentioned this pull request Sep 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbates130272 sbates130272 sbates130272 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TyKeeling @sbates130272