Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: do not automatically add name field in package.json for apps #3370

Merged
merged 1 commit into from
Jun 2, 2022
Merged

ci: do not automatically add name field in package.json for apps #3370

merged 1 commit into from
Jun 2, 2022

Conversation

pcattori
Copy link
Contributor

@pcattori pcattori commented Jun 2, 2022

Another PR targets main. Targeting dev in this PR so that CI doesn't automatically create name fields on dev that will conflict when we try to merge dev back into main.

@pcattori pcattori requested a review from mcansh June 2, 2022 21:41
@pcattori pcattori mentioned this pull request Jun 2, 2022
Merged
@pcattori pcattori merged commit 5f979ca into dev Jun 2, 2022
@pcattori pcattori deleted the pedro/no-automatic-names-for-apps branch June 2, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcansh mcansh mcansh approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pcattori @mcansh