Fix connection leaks in dependencies by monkey patching gevent queues #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RoganMurley
commented
Mar 28, 2022
| @@ -24,7 +25,6 @@ | |||
| from typing import Optional | |||
| from typing import TYPE_CHECKING | |||
|
|
|||
| from gevent import queue as gevent_queue | |||
There was a problem hiding this comment.
Undoing explicitly using a gevent queue, because the standard library queue should be patched.
RoganMurley
commented
Mar 28, 2022
| @@ -0,0 +1,13 @@ | |||
| from gevent.monkey import patch_module | |||
There was a problem hiding this comment.
Was unsure where to put this file.
bradengroom
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connection pools implemented using standard library queues can leak connections when a gevent timeout exception is raised. To avoid this gevent queues should be used rather than standard library queues.
We fixed this in baseplate.py Thrift pools, but there are still many such issues in dependencies. In some cases we can explicitly use a gevent queue, but in other cases we have to monkey patch.
Previously we did not monkey patch because it is unclear why gevent
patch_queueandpatch_alldoes not patch by default. I've raised an issue asking the gevent team about this, and also started canarying such a change in a Reddit service that was experiencing Kombu connection leaks. The service hasn't experienced any issues with the change so I'd like to merge it upstream.