Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playdigo: new adapter #5274

Merged
merged 5 commits into from
May 10, 2024
Merged

Playdigo: new adapter #5274

merged 5 commits into from
May 10, 2024

Conversation

Yanivplaydigo
Copy link
Contributor

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

📋 Checklist

  • Related pull requests in prebid.js or server are linked -> Paste link in this list or reference it on the PR itself
  • For new adapters check submitting your adapter docs

Copy link

netlify bot commented Apr 22, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit cd04c4e
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/662970d9cb0e4b0008dbb883
😎 Deploy Preview https://deploy-preview-5274--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider adding the rest of the metadata missing from this list as described in https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter . e.g deals_suported, ortb_blocking_supported, tcfeu_supported, etc.

Also - most bid adapters will place contact info at the top, e.g. "to register with Playdigo, please contact ___"

coppa_supported: true
schain_supported: true
floors_supported: true
gpp_supported: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry - gpp_supported is no longer a valid piece of metadata. It's been replaced with gpp_sids as described in https://docs.prebid.org/dev-docs/bidder-adaptor.html#submitting-your-adapter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your reply, we have made changes

@bretg bretg removed the LGTM label Apr 24, 2024
@muuki88 muuki88 merged commit 568dbb8 into prebid:master May 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants