-
Notifications
You must be signed in to change notification settings - Fork 1.3k
renamed idWardRtdProvider to anonymisedRtdProvider #4702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing module names can only be done like this at major releases because it could be a confusing breaking change for publishers who build Prebid.js with a script including the old name.
The policy is that you have to leave the old name up for a transition period. Documentation for the old name can be simple "module has has been renamed, please see ____"
|
Right - the rule is that you have to leave the old name up until the next major release, which is 9.0 So this PR could be merged if you update it to not delete the old name and instead point people to the new name. |
@bretg I've recovered the old module so that it coexists with the new module for backward compatibility. I'll deprecate the old module after the major release. Documentation has been updated accordingly. |
Ok, but the code doesn't reflect this yet. Added a comment to prebid/Prebid.js#10176 |
Ok - sorry - I merged too soon. The code PR wasn't merged yet. So I reverted the docs change until the code is done prebid/Prebid.js#10176 |
I believe that the prebid/Prebid.js#10176 is done |
Hi @bretg, The code PR has been merged. Could you recover the documents PR? c.c. @jon-caines-idward |
done and merged |
Thank you @bretg |
Renamed idWardRtdProvider RTD module to anonymisedRtdProvider and all the "ID Ward" mentions to "Anonymised" because the company https://id-ward.com has been renamed to https://www.anonymised.io/.
idWardRtdProvider module is maintained for backward compatibility until the next major Prebid release.
🏷 Type of documentation
📋 Checklist