Skip to content

renamed idWardRtdProvider to anonymisedRtdProvider #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jan 4, 2024

Conversation

kyrylenko
Copy link
Contributor

@kyrylenko kyrylenko commented Jul 3, 2023

Renamed idWardRtdProvider RTD module to anonymisedRtdProvider and all the "ID Ward" mentions to "Anonymised" because the company https://id-ward.com has been renamed to https://www.anonymised.io/.
idWardRtdProvider module is maintained for backward compatibility until the next major Prebid release.

🏷 Type of documentation

  • text edit only (wording, typos)

📋 Checklist

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit bb2f93a
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/6596c78ba16092000878c6c9
😎 Deploy Preview https://deploy-preview-4702--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing module names can only be done like this at major releases because it could be a confusing breaking change for publishers who build Prebid.js with a script including the old name.

The policy is that you have to leave the old name up for a transition period. Documentation for the old name can be simple "module has has been renamed, please see ____"

@bretg bretg added needs work and removed LGTM labels Jul 27, 2023
@kyrylenko
Copy link
Contributor Author

Changing module names can only be done like this at major releases because it could be a confusing breaking change for publishers who build Prebid.js with a script including the old name.

The policy is that you have to leave the old name up for a transition period. Documentation for the old name can be simple "module has has been renamed, please see ____"
Hi @bretg! We're targeting the major release v9.0.0. So can we deprecate the old module name? Or do I still have to maintain the old name?

@bretg
Copy link
Contributor

bretg commented Dec 14, 2023

Right - the rule is that you have to leave the old name up until the next major release, which is 9.0

So this PR could be merged if you update it to not delete the old name and instead point people to the new name.

@kyrylenko
Copy link
Contributor Author

@bretg I've recovered the old module so that it coexists with the new module for backward compatibility. I'll deprecate the old module after the major release. Documentation has been updated accordingly.
Thanks for your tip!

@bretg bretg added LGTM and removed needs work labels Dec 14, 2023
@bretg
Copy link
Contributor

bretg commented Dec 14, 2023

Ok, but the code doesn't reflect this yet. Added a comment to prebid/Prebid.js#10176

@bretg bretg merged commit 83459f8 into prebid:master Jan 4, 2024
bretg added a commit that referenced this pull request Jan 4, 2024
bretg added a commit that referenced this pull request Jan 4, 2024
@bretg
Copy link
Contributor

bretg commented Jan 4, 2024

Ok - sorry - I merged too soon. The code PR wasn't merged yet. So I reverted the docs change until the code is done prebid/Prebid.js#10176

@kyrylenko
Copy link
Contributor Author

Ok - sorry - I merged too soon. The code PR wasn't merged yet. So I reverted the docs change until the code is done prebid/Prebid.js#10176

I believe that the prebid/Prebid.js#10176 is done

@kyrylenko
Copy link
Contributor Author

Ok - sorry - I merged too soon. The code PR wasn't merged yet. So I reverted the docs change until the code is done prebid/Prebid.js#10176

Hi @bretg, The code PR has been merged. Could you recover the documents PR? c.c. @jon-caines-idward

@bretg
Copy link
Contributor

bretg commented May 7, 2024

done and merged

@jon-caines-idward
Copy link

Thank you @bretg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants