fix bidTimeout event (#3583) #3696
Conversation
|
@thewizarodofoz I don't think there is enough detail in the timeout event to distinguish the sub requests for a particular adunit auction. Does this distinguish between ad units though? A timeout of one adunit's bid requests versus another is valuable diagnostically and not all bidders bundle their requests into one. I think this fix without that is better than the current behavior, but adunit level differentation is implied in the data model of the event. |
|
@GLStephen I agree. I couldn't find a way to distinguish between ad units currently, because a bidder gets all the ad units' params as a bundle, and the breaking down into one or more requests is up to the bidder. Then the bidder informs the auction object only about valid bid responses. Meaning that no bid on an ad unit is just like no response at all. Obviously anything is possible, but as far as I can see, in order to distinguish between ad units, bidders will need to inform the auction about the result of each request (wether it has a bid or not). It will require a pretty dramatic change and an update of all bidders. Maybe @mkendall07 or @jsnellbaker will have better ideas about this. |
|
@thewizarodofoz Can you please resolve the code conflicts? |
Type of change
Description of change
In Prebid 2.x the BID_TIMEOUT event was emitted for bidders which responded in time but yielded no bids. This is now fixed - a bidder which responded in time is considered a timely bidder, even if it responded with no bids.
This fixes #3583 .
NOTE: When a bidder responds, we assume that it responded to all its bid requests in the auction. This might not be 100% desired behaviour, but it was the behaviour in 1.x so I decided to keep it this way.
NOTE2: Even an error response is considered a timely response.