Adnuntius Bid Adapter: standardise kv targeting value handling when sent to adserver #11721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
433976c
to
0504552
Compare
patmmccann
reviewed
Jun 7, 2024
modules/adnuntiusBidAdapter.js
Outdated
| @@ -22,6 +22,15 @@ export const misc = { | |||
| getUnixTimestamp: function (addDays, asMinutes) { | |||
| const multiplication = addDays / (asMinutes ? 1440 : 1); | |||
| return Date.now() + (addDays && addDays > 0 ? (1000 * 60 * 60 * 24 * multiplication) : 0); | |||
| }, | |||
| convertObjectToArray: function(obj) { | |||
There was a problem hiding this comment.
This looks like it should be a utility in utils folder
There was a problem hiding this comment.
OK -- I've pushed both functions into the utils.js file and available now for anyone else.
2bca149
to
94bb71c
Compare
94bb71c
to
95e400f
Compare
patmmccann
approved these changes
Jun 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Standardises how kv targeting data is sent to the adserver.
Kv targeting specified as an object and kvs from rtb information are converted to an array to avoid clashing with kv targeting specified as an array and to allow separate objects with the same key to be sent to the adserver via the array.
Other information