Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sirdata RTD Module : add eids and post content support and get ready for PBJS 9.0 #11524

Merged
merged 11 commits into from
May 28, 2024
Merged

Sirdata RTD Module : add eids and post content support and get ready for PBJS 9.0 #11524

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a35f88a
Add eids and post content suport
nouchy May 20, 2024
0300f1c
multi-character sanitization
nouchy May 20, 2024
0eb83e5
recursively removing elements to avoid an HTML element injection vuln…
nouchy May 21, 2024
3409423
fix expression vs expected assignment
nouchy May 21, 2024
b99e7b2
fix return statement for loop
nouchy May 21, 2024
7188b5d
run completeSanitization instead of sanitizeContent
nouchy May 21, 2024
c6dbf11
fix multi-character sanitization
nouchy May 21, 2024
b828517
Update sirdataRtdProvider.js
nouchy May 21, 2024
0fea181
fix missing moduleConfig param
nouchy May 22, 2024
96e7752
Add filtering eids based on whitelist
nouchy May 24, 2024
b24baf9
fixe default Eids
nouchy May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix expression vs expected assignment
  • Loading branch information
@nouchy
nouchy committed May 21, 2024
commit 340942364091b3e0684327581d2adab6bfee6dd8
2 changes: 1 addition & 1 deletion modules/sirdataRtdProvider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@
// Clean any potential PII
content.documentElement.innerHTML = removePII(content.documentElement.innerHTML);
// Compress the content
content.documentElement.innerHTML = content.documentElement.innerHTML.replace(/\s+/g, ' ').replace(/>\s+</g, '><').replace(/<!--[\s\S]*?-->/g, '')
github-advanced-security[bot] marked this conversation as resolved.
Fixed Show resolved Hide resolved
}
return content;
}
Expand Down Expand Up @@ -681,7 +681,7 @@
if (xandrData.segments.length > 0) {
setOrtb2(reqBids.ortb2Fragments?.bidder, bid.bidder, 'user.keywords', `sd_rtd=${xandrData.segments.join(',sd_rtd=')}`);
}
if (sirdataData.categories.length > 0) {
if (xandrData.categories.length > 0) {
setOrtb2(reqBids.ortb2Fragments?.bidder, bid.bidder, 'site.content.keywords', `sd_rtd=${xandrData.categories.join(',sd_rtd=')}`);
}
} else {
Expand Down