Cadent Aperture MX Bid Adapter: Include gpp consent in usersync endpoint #10404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertrmartinez
approved these changes
Aug 29, 2023
| } | ||
| if (gppConsent.applicableSections && typeof gppConsent.applicableSections === 'object') { | ||
| consentParams.push(`gpp_sid=${gppConsent.applicableSections}`); | ||
| } |
There was a problem hiding this comment.
I believe these checks can be simplified since you already check that gppConsent is an object
if (typeof gppConsent.gppString === 'string') {if (Array.isArray(gppConsent.applicableSections)) {Or just use optional chaining
if (typeof gppConsent?.gppString === 'string') {if (Array.isArray(gppConsent?.applicableSections)) {There was a problem hiding this comment.
This PR is approved already. we have noted the suggested change and plan push it as part of another PR or maintenance change. @robertrmartinez
|
One suggestion, though not required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Include gpp string and section id in usersync endpoint
Other information