Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[policy] Now enforcing code coverage on PRs and on bidder adapters #421

Closed
mkendall07 opened this issue Jun 21, 2016 · 0 comments
Closed

[policy] Now enforcing code coverage on PRs and on bidder adapters #421

mkendall07 opened this issue Jun 21, 2016 · 0 comments
Labels
feature notification

Comments

@mkendall07
Copy link
Member

mkendall07 commented Jun 21, 2016 •
edited

Prebid.js community:

As we are growing steadily and the project is maturing, we are starting to formalize more policy around code changes and PRs.

Starting now all PRs submitted will need > 80% code coverage for changed/added code before being merged into master. This will be enforced by the Prebid.js core team.

Thanks for reading and thanks for supporting Prebid.js!
rmloveland pushed a commit to prebid/prebid.github.io that referenced this issue Jul 19, 2016
RAD-972 Add docs for testing the Prebid.js library
9924296 
See also: prebid/Prebid.js#421

Original version of these docs was written by @matthewlane, I just did
some edits/cleanup.  Thanks Matt!
@rmloveland rmloveland mentioned this issue Jul 19, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature notification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkendall07