Update the spec: include iframe header and relaxed filtering #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the spec to include <iframe> request header and relaxed filtering behavior. Those new behaviors were added after the spec was drafted. patcg-individual-drafts#145 patcg-individual-drafts#143
|
@domenic PTAL. Thanks! |
domenic
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
Looks good with editorial issues around defining and linking content and IDL attributes. I think my suggestions will suffice to fix them, but you might need a bit of tweaking... Relevant docs at https://speced.github.io/bikeshed/#dfn-types and https://speced.github.io/bikeshed/#autolink-wrappers .
Feel free to re-request review or ping if necessary.
github-actions bot
added a commit
that referenced
this pull request
Mar 30, 2023
SHA: 8fb298f Reason: push, by xyaoinum Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to admariner/topics-API
that referenced
this pull request
Apr 29, 2023
…pec-include-new-behavior SHA: 8fb298f Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to durangoe/topics
that referenced
this pull request
Apr 29, 2023
…pec-include-new-behavior SHA: 8fb298f Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the spec to include <iframe> request header and relaxed filtering behavior. Those new behaviors were added after the spec was drafted. #145 #143