Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contribution bound and add new 'backstop' bound #45

Merged
merged 1 commit into from
May 22, 2023

Conversation

alexmturner
Copy link
Collaborator

Switches from per-origin per-day budgets to per-site per-10 min. Also adds a new per-site per-day looser budget as a backstop to prevent worst-case leakage.

See original proposal here:
#23 (comment)

Switches from per-origin per-day budgets to per-site per-10 min. Also
adds a new per-site per-day looser budget as a backstop to prevent
worst-case leakage.

See original proposal here:
#23 (comment)
@alexmturner
Copy link
Collaborator Author

@linnan-github, could you PTAL? Thanks!

@alexmturner alexmturner merged commit aa1854b into main May 22, 2023
@alexmturner alexmturner deleted the budgeting-scope branch May 22, 2023 17:58
aarongable pushed a commit to chromium/chromium that referenced this pull request May 30, 2023
Switches the bound from being per-origin per-day per-API, to per-site
per-10 min per-API. Also adds a new per-site per-day per-API looser
bound as a backstop to prevent worst-case leakage. The budget data is
stored on disk in 1440 separate minute-long windows, replacing the 24
hour-long windows before. We do not use separate stores for the two
budgets.

This cl also bumps the storage version, which will raze any existing
stored budgets. It also updates the data deletion logic to handle the
per-site scope, retaining references to the origins that have used it
in the last day to support per-origin deletion. (Note that all data for
the site will be deleted in case of an origin match, however.)

See also
patcg-individual-drafts/private-aggregation-api#45

Bug: 1446822
Change-Id: I877a8e6f2e7a8a5b9ea308ee07eadd22112c5416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4543883
Commit-Queue: David Bokan <[email protected]>
Reviewed-by: Nan Lin <[email protected]>
Reviewed-by: Charlie Harrison <[email protected]>
Reviewed-by: David Bokan <[email protected]>
Commit-Queue: Alex Turner <[email protected]>
Auto-Submit: Alex Turner <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1150638}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants