Refactor and add support for Inky Impression 7.3" #49

axelson · 2023-08-07T03:36:23Z

The Inky Impression 7.3" uses a different chip than the Impression 5.7" and 4" so it required a new HAL module.

To fit this new chip support into the library I also undertook a refactor

Rename the phat to phat_original
- I would have used the chip name instead of "original" but I haven't been able to find the name of the chip anywhere
Segregate HAL for phat and impression based on chip type
Compile test/support when MIX_TARGET=test

I have tested this on (using https://github.com/axelson/inky_tester):

Inky pHAT SSD1608
Inky Impression 5.7"
Inky Impression 7.3"

This merges the contents of the impression branch which also includes code/work from @lawik and @jasonmj ❤️

…n't open

Fixes a off by one error

Just put a comment instead of an actual call in case we want to restore the calls later.

Jax/inky impression

Impression

There's no code changes, only the version number has been updated: https://github.com/elixir-circuits/circuits_gpio/blob/cc7d77479a4d2ffba1a24962ad067f4680003de4/CHANGELOG.md#v100---10-20-2021

Support circuits_gpio 1.0

Add support for buttons on Inky Impression

Rename the phat to phat_original Segregate HAL for phat and impression based on chip type Compile test/support when MIX_TARGET=test

There's no breaking changes except for a small one in circuits spi 1.4.0 that says "Remove Erlang convenience functions since no one used them"

jasonmj · 2023-08-09T01:08:15Z

I would have used the chip name instead of "original" but I haven't been able to find the name of the chip anywhere

I did some searching and found IL91874 at the top of the original python code. Maybe that's it?

jasonmj

Lookin great! Here's a first pass with plenty of small suggestions and some questions. I don't think anything here is a blocker really, but I'd be happy to see some of these changes.

lib/buttons.ex

jasonmj · 2023-08-09T01:26:31Z

lib/display/display.ex

+ }
+ end
+
+ # WARNING: This is untested on actual hardware


Hmm, I wonder if Pimoroni would be willing to send us one? I went ahead and wrote a quick note to their support team to see if there's a chance.

Pimoroni is sending me a 4" Impression for testing 🎉

Wow, that's great!!

README.md

jasonmj · 2023-08-09T12:56:08Z

lib/hal/hal_impression_uc8159.ex

+ end
+
+ #
+ # pipe-able wrappers


Since these are re-used, does it make sense to put them into a common helper module?

jasonmj · 2023-08-09T12:57:00Z

lib/hal/io_impression.ex

+
+ spi_address = "spidev0." <> to_string(pin_mappings[:spi])
+
+ IO.puts("opening DC pin")


In other places, we're using Logger. Probably best to be consistent and use Logger here too.

jasonmj · 2023-08-09T12:57:20Z

lib/hal/io_impression.ex

+ spi_write(state, @spi_command, value)
+ end
+
+ require Logger


lib/hal/io_impression.ex

jasonmj

Lookin great! Here's a first pass with plenty of small suggestions and some questions. I don't think anything here is a blocker really, but I'd be happy to see some of these changes.

nyaray · 2023-08-09T15:45:56Z

So glad to see this continues to get usage/updates, nothing constructive to add, really. ✌️

axelson · 2023-08-13T05:23:30Z

I would have used the chip name instead of "original" but I haven't been able to find the name of the chip anywhere

I did some searching and found IL91874 at the top of the original python code. Maybe that's it?

Well spotted! Updated in 975d63b

Also improve the moduledocs

lawik and others added 30 commits October 10, 2021 14:44

Start work on on Inky Impression

7d80cce

More work on setup and update for Inky Impression

8ee2dda

Add all of the Impression code but not working, added cs0 but that wo…

6e11741

…n't open

Kinda working!

c56c9be

Kind of like a flag

e415e0e

Fixes a off by one error

Cleaning

fc37b1f

Clean up cs pin calls

cc82eda

Just put a comment instead of an actual call in case we want to restore the calls later.

clean

99d2cd5

Merge pull request pappersverk#42 from axelson/jax/inky-impression

7a636df

Jax/inky impression

Fix log typo

753d5a8

Adds comments to byte commands defined for Impression in hal

3f46d9a

Fix typo in comment

3142798

Update mix deps for development on jasonmj

ae2e48f

Update display definition for impression

07f75e6

Add handling for impression in packed_width and packed_height

63cdb4f

Fix usage of state in log function

13793cd

Add set_dimensions to do_update for impression

853021b

Replace buffer generation with PixelUtil.pixels_to_bits

46a3b40

Add a color_map for the impression

9dfa181

Add notes about WIP toward impression support

5bfb57f

Reverting dev changes to mix.exs

4689834

Cleaning up unused code

3bcf4f1

Adding bit_size option to PixelUtil.pixels_to_bits

590c25f

Merge pull request pappersverk#46 from jasonmj/impression

d5bca11

Impression

Cleans up code for PR

9abc79f

Adds painter test

80bdee8

Support circuits_gpio 1.0

f86d1b8

There's no code changes, only the version number has been updated: https://github.com/elixir-circuits/circuits_gpio/blob/cc7d77479a4d2ffba1a24962ad067f4680003de4/CHANGELOG.md#v100---10-20-2021

Merge pull request pappersverk#47 from axelson/impression

b30be19

Support circuits_gpio 1.0

Add support for buttons on Inky Impression

a68e31a

Support sending button messages to a process by registered atom name

40cda84

lawik and others added 4 commits August 1, 2022 17:16

Merge pull request pappersverk#48 from jasonmj/impression

6a6cd42

Add support for buttons on Inky Impression

WIP

35eb6cd

Merge remote-tracking branch 'origin/master' into impression73-messy

765d6ff

Refactor!

2fa18a3

Rename the phat to phat_original Segregate HAL for phat and impression based on chip type Compile test/support when MIX_TARGET=test

This was referenced Aug 7, 2023

[Do not merge] Jax inky impression messy #45

Closed

Start work on on Inky Impression #37

Closed

axelson added 2 commits August 6, 2023 17:43

Fix credo issues

5d65f09

Allow newer versions of circuits libraries

f6e11c7

There's no breaking changes except for a small one in circuits spi 1.4.0 that says "Remove Erlang convenience functions since no one used them"

jasonmj self-requested a review August 9, 2023 00:55

jasonmj reviewed Aug 9, 2023

View reviewed changes

Rename phat_original to phat_il91874

975d63b

axelson added 4 commits August 12, 2023 19:41

Rename Buttons to ImpressionButtons

4174f7e

Also improve the moduledocs

Improve the readme

c81122d

Rename bit_size to bit_count

83a37a8

IO.Phat moduledoc

535ba1d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor and add support for Inky Impression 7.3" #49

Refactor and add support for Inky Impression 7.3" #49

axelson commented Aug 7, 2023

jasonmj commented Aug 9, 2023

jasonmj left a comment

jasonmj Aug 9, 2023

jasonmj Aug 11, 2023

axelson Aug 13, 2023

jasonmj Aug 9, 2023

jasonmj Aug 9, 2023 •

edited

Loading

jasonmj Aug 9, 2023

jasonmj left a comment

nyaray commented Aug 9, 2023

axelson commented Aug 13, 2023


		spi_address = "spidev0." <> to_string(pin_mappings[:spi])

		IO.puts("opening DC pin")

Refactor and add support for Inky Impression 7.3" #49

Are you sure you want to change the base?

Refactor and add support for Inky Impression 7.3" #49

Conversation

axelson commented Aug 7, 2023

jasonmj commented Aug 9, 2023

jasonmj left a comment

Choose a reason for hiding this comment

jasonmj Aug 9, 2023

Choose a reason for hiding this comment

jasonmj Aug 11, 2023

Choose a reason for hiding this comment

axelson Aug 13, 2023

Choose a reason for hiding this comment

jasonmj Aug 9, 2023

Choose a reason for hiding this comment

jasonmj Aug 9, 2023 • edited Loading

Choose a reason for hiding this comment

jasonmj Aug 9, 2023

Choose a reason for hiding this comment

jasonmj left a comment

Choose a reason for hiding this comment

nyaray commented Aug 9, 2023

axelson commented Aug 13, 2023

jasonmj Aug 9, 2023 •

edited

Loading