📖 Update name of Branch Protection Rule 📖 #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
|
Integration tests success for |
|
Will this change also apply to the description given on the Remediation Steps section when you open the "Branch Protection" alert on the security tab? I've tried in a personal project, calling Scorecards with |
|
I think it's because the code at main does not call the scorecard at main: it still uses the latest version from Dec https://github.com/ossf/scorecard-action/blob/main/action.yaml#L56 |
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly Signed-off-by: Diogo Teles Sant'Anna <[email protected]> Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Apr 4, 2023
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly Signed-off-by: Diogo Teles Sant'Anna <[email protected]> Signed-off-by: Diogo Teles Sant'Anna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On GitHub Branch-Protection configuration there was a rule called "Include administrator", which forced the admins to follow the same rules. It was renamed to "Do not allow bypassing the above settings", we we're updating scorecard accordingly.
Signed-off-by: Diogo Teles Sant'Anna [email protected]
What kind of change does this PR introduce?
Docs Update
Which issue(s) this PR fixes
No issue created
Special notes for your reviewer
Talked to @laurentsimon before creating this PR.
Does this PR introduce a user-facing change?
No